kimmking commented on a change in pull request #4682: Refactor orchestration
phase 1.1
URL:
https://github.com/apache/incubator-shardingsphere/pull/4682#discussion_r390074343
##########
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/yaml/swapper/InstanceConfigurationYamlSwapper.java
##########
@@ -34,13 +34,13 @@
*/
@Override
public YamlInstanceConfiguration swap(final InstanceConfiguration data) {
- YamlInstanceConfiguration result = new YamlInstanceConfiguration();
- result.setOrchestrationType(data.getOrchestrationType());
- result.setInstanceType(data.getType());
- result.setServerLists(data.getServerLists());
- result.setNamespace(data.getNamespace());
- result.setProps(data.getProperties());
- return result;
+ YamlInstanceConfiguration yamlInstanceConfiguration = new
YamlInstanceConfiguration();
+
yamlInstanceConfiguration.setOrchestrationType(data.getOrchestrationType());
+ yamlInstanceConfiguration.setInstanceType(data.getType());
+ yamlInstanceConfiguration.setServerLists(data.getServerLists());
+ yamlInstanceConfiguration.setNamespace(data.getNamespace());
+ yamlInstanceConfiguration.setProps(data.getProperties());
+ return yamlInstanceConfiguration;
Review comment:
> The result variable need to rename as result
why use result as variable name？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
