This is an automated email from the ASF dual-hosted git repository.

totalo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1283c2d1005 Remove useless codes (#29133)
1283c2d1005 is described below

commit 1283c2d1005ac7a00069e1f4d76244acf085e8fc
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Nov 23 14:59:35 2023 +0800

    Remove useless codes (#29133)
---
 .../repository/PipelineJobOffsetGovernanceRepository.java  | 14 --------------
 .../core/job/service/GovernanceRepositoryAPIImplTest.java  | 10 ----------
 2 files changed, 24 deletions(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/common/registrycenter/repository/PipelineJobOffsetGovernanceRepository.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/common/registrycenter/repository/PipelineJobOffsetGovernanceRepository.java
index 412f78e4e6e..c007b67574f 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/common/registrycenter/repository/PipelineJobOffsetGovernanceRepository.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/common/registrycenter/repository/PipelineJobOffsetGovernanceRepository.java
@@ -26,9 +26,6 @@ import 
org.apache.shardingsphere.data.pipeline.common.metadata.node.PipelineMeta
 import org.apache.shardingsphere.infra.util.yaml.YamlEngine;
 import 
org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepository;
 
-import java.util.List;
-import java.util.stream.Collectors;
-
 /**
  * Pipeline job offset governance repository.
  */
@@ -57,15 +54,4 @@ public final class PipelineJobOffsetGovernanceRepository {
         String value = 
repository.getDirectly(PipelineMetaDataNode.getJobOffsetPath(jobId));
         return new 
YamlJobOffsetInfoSwapper().swapToObject(Strings.isNullOrEmpty(value) ? new 
YamlJobOffsetInfo() : YamlEngine.unmarshal(value, YamlJobOffsetInfo.class));
     }
-    
-    /**
-     * Get sharding items of job.
-     *
-     * @param jobId job id
-     * @return sharding items
-     */
-    public List<Integer> getShardingItems(final String jobId) {
-        List<String> result = 
repository.getChildrenKeys(PipelineMetaDataNode.getJobOffsetPath(jobId));
-        return 
result.stream().map(Integer::parseInt).collect(Collectors.toList());
-    }
 }
diff --git 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/job/service/GovernanceRepositoryAPIImplTest.java
 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/job/service/GovernanceRepositoryAPIImplTest.java
index 0e3e0ff9312..0ff4eaa6273 100644
--- 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/job/service/GovernanceRepositoryAPIImplTest.java
+++ 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/job/service/GovernanceRepositoryAPIImplTest.java
@@ -43,7 +43,6 @@ import org.junit.jupiter.api.Test;
 
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.concurrent.CountDownLatch;
@@ -155,15 +154,6 @@ class GovernanceRepositoryAPIImplTest {
         
assertTrue(governanceRepositoryAPI.getJobOffsetGovernanceRepository().load("1").isTargetSchemaTableCreated());
     }
     
-    @Test
-    void assertGetShardingItems() {
-        MigrationJobItemContext jobItemContext = mockJobItemContext();
-        
governanceRepositoryAPI.getJobItemProcessGovernanceRepository().persist(jobItemContext.getJobId(),
 jobItemContext.getShardingItem(), "testValue");
-        List<Integer> shardingItems = 
governanceRepositoryAPI.getJobOffsetGovernanceRepository().getShardingItems(jobItemContext.getJobId());
-        assertThat(shardingItems.size(), is(1));
-        assertThat(shardingItems.get(0), is(jobItemContext.getShardingItem()));
-    }
-    
     private ClusterPersistRepository getClusterPersistRepository() {
         ContextManager contextManager = 
PipelineContextManager.getContext(PipelineContextUtils.getContextKey()).getContextManager();
         return (ClusterPersistRepository) 
contextManager.getMetaDataContexts().getPersistService().getRepository();

Reply via email to