sandynz commented on code in PR #29277:
URL: https://github.com/apache/shardingsphere/pull/29277#discussion_r1413828283
##########
kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/CDCJobAPI.java:
##########
@@ -226,6 +226,7 @@ private void enable(final String jobId) {
jobConfigPOJO.setDisabled(false);
jobConfigPOJO.getProps().setProperty("start_time_millis",
String.valueOf(System.currentTimeMillis()));
jobConfigPOJO.getProps().remove("stop_time_millis");
+ jobConfigPOJO.getProps().remove("stop_time");
Review Comment:
Could we just save `stop_time` or `stop_time_millis` in registry center?
##########
kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/OpenGaussWALDumper.java:
##########
@@ -96,7 +94,7 @@ protected void runBlocking() {
int times = reconnectTimes.incrementAndGet();
log.error("Connect failed, reconnect times={}", times, ex);
if (isRunning()) {
- Thread.sleep(5000L);
+ sleepIgnoreInterrupt(5000L);
Review Comment:
When InterruptedException is thrown, `break` while loop might be necessary,
but not just ignore it. It might cause dumper could not be paused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
