RaigorJiang commented on code in PR #29269:
URL: https://github.com/apache/shardingsphere/pull/29269#discussion_r1419093426
##########
features/shadow/distsql/parser/src/main/antlr4/imports/shadow/RQLStatement.g4:
##########
@@ -43,6 +43,10 @@ countShadowRule
: COUNT SHADOW RULE (FROM databaseName)?
;
+tableRule
+ :RULE tableName
Review Comment:
Please keep the format consistent: there is a space after the colon
##########
features/shadow/distsql/parser/src/main/java/org/apache/shardingsphere/shadow/distsql/parser/core/ShadowDistSQLStatementVisitor.java:
##########
@@ -152,7 +152,7 @@ public ASTNode visitShowShadowRules(final
ShowShadowRulesContext ctx) {
@Override
public ASTNode visitShowShadowTableRules(final ShowShadowTableRulesContext
ctx) {
- return new ShowShadowTableRulesStatement(null == ctx.databaseName() ?
null : (DatabaseSegment) visit(ctx.databaseName()));
+ return new ShowShadowTableRulesStatement(null == ctx.databaseName() ?
null : (DatabaseSegment) visit(ctx.databaseName()), "");
Review Comment:
In this visitor method, we should get table name from ctx and put into
statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
