zihaoAK47 commented on code in PR #29610:
URL: https://github.com/apache/shardingsphere/pull/29610#discussion_r1440029677
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4:
##########
@@ -279,10 +283,51 @@ autonomousTransPragma
: PRAGMA AUTONOMOUS_TRANSACTION SEMI_
;
-dmlEventClause
- : dmlEventElement (OR dmlEventElement)* ON viewName
+plsqlTriggerSource
+ : (schemaName DOT_)? triggerName sharingClause? defaultCollationClause?
(simpleDmlTrigger | systemTrigger)
;
-dmlEventElement
- : (DELETE | INSERT | UPDATE) (OF LP_ columnName (COMMA_ columnName)* RP_)?
+simpleDmlTrigger
+ : (BEFORE | AFTER) dmlEventClause
+ ;
+
+dmlEventClause
+ : dmlEventTrigger (OR dmlEventTrigger)* ON viewName
+ ;
+
+dmlEventTrigger
+ : DELETE
Review Comment:
Please keep these branches in one line.
Refer code conduct -
https://shardingsphere.apache.org/community/en/involved/conduct/code/.
> If a rule’s branch is over than 5, every branch take a new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
