ilyasahsan123 commented on PR #29654:
URL: https://github.com/apache/shardingsphere/pull/29654#issuecomment-1876969592

   hi @zihaoAK47 @strongduanmu,
   
   Changes are:
   
   1. Remove duplication in `executeImmediateStatement`.
   2. Enhance the unit test sql. It turns out, we need pl/sql block statement. 
([details](https://docs.oracle.com/cd/B13789_01/server.101/b10759/statements_7004.htm))
   
![image](https://github.com/apache/shardingsphere/assets/14249648/90814084-960c-4d7d-9dbb-7cfd96692fa4)
   3. Support the following create trigger statement
   ```
   CREATE TRIGGER Contacts_BI
       BEFORE INSERT ON Contacts FOR EACH ROW
   BEGIN
       :NEW.ID := Contacts_Seq.NEXTVAL;
   END;
   ```
   
   Feel free if you have any concern. I'll address them promptly. 
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to