RaigorJiang commented on code in PR #29664:
URL: https://github.com/apache/shardingsphere/pull/29664#discussion_r1443975724
##########
kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/channel/memory/MemoryPipelineChannelTest.java:
##########
@@ -40,7 +40,15 @@ void assertZeroQueueSizeWorks() {
List<Record> records = Collections.singletonList(new
PlaceholderRecord(new IngestFinishedPosition()));
Thread thread = new Thread(() -> channel.push(records));
thread.start();
- assertThat(channel.fetch(1, 500L), is(records));
+ assertThat(channel.fetch(1, 5L), is(records));
thread.join();
}
+
+ @Test
+ void assertFetchWithZeroTimeout() {
+ MemoryPipelineChannel channel = new MemoryPipelineChannel(100, new
InventoryTaskAckCallback(new AtomicReference<>()));
+ List<Record> records = Collections.singletonList(new
PlaceholderRecord(new IngestFinishedPosition()));
Review Comment:
Should `List<Record>` be declared as `Collection<Record>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
