strongduanmu commented on code in PR #29860:
URL: https://github.com/apache/shardingsphere/pull/29860#discussion_r1467248875


##########
parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/dml/SelectStatementHandler.java:
##########
@@ -231,4 +232,27 @@ public static void setModelSegment(final SelectStatement 
selectStatement, final
             ((OracleSelectStatement) 
selectStatement).setModelSegment(modelSegment);
         }
     }
+    
+    /**
+     * Get into segment.
+     * @param selectStatement select statement

Review Comment:
   Please add a new line between javadoc and param doc.



##########
parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/sqlserver/dml/SQLServerSelectStatement.java:
##########
@@ -52,4 +55,12 @@ public Optional<LimitSegment> getLimit() {
     public Optional<WithSegment> getWithSegment() {
         return Optional.ofNullable(withSegment);
     }
+    
+    /**
+     * Get into segment.
+     * @return into segment

Review Comment:
   Please add a new line between javadoc and param doc.



##########
parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/dml/SelectStatementHandler.java:
##########
@@ -231,4 +232,27 @@ public static void setModelSegment(final SelectStatement 
selectStatement, final
             ((OracleSelectStatement) 
selectStatement).setModelSegment(modelSegment);
         }
     }
+    
+    /**
+     * Get into segment.
+     * @param selectStatement select statement
+     * @return into table segment
+     */
+    public static Optional<TableSegment> getIntoSegment(final SelectStatement 
selectStatement) {
+        if (selectStatement instanceof SQLServerSelectStatement) {
+            return ((SQLServerSelectStatement) 
selectStatement).getIntoSegment();
+        }
+        return Optional.empty();
+    }
+    
+    /**
+     * Set into segment.
+     * @param selectStatement select statement

Review Comment:
   Please add a new line between javadoc and param doc.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to