This is an automated email from the ASF dual-hosted git repository.
zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 682f0691d7a Remove useless static assertions (#29879)
682f0691d7a is described below
commit 682f0691d7a8dd07ecd70b7c0fa21bcd51a90590
Author: Liang Zhang <[email protected]>
AuthorDate: Sat Jan 27 23:28:10 2024 +0800
Remove useless static assertions (#29879)
---
.../ExportDatabaseConfigurationExecutorTest.java | 7 -------
.../ral/queryable/ExportMetaDataExecutorTest.java | 11 -----------
.../ral/queryable/ExportStorageNodesExecutorTest.java | 11 -----------
.../ral/queryable/ShowComputeNodeInfoExecutorTest.java | 17 -----------------
.../ral/queryable/ShowDistVariableExecutorTest.java | 11 -----------
...owStatusFromReadwriteSplittingRulesExecutorTest.java | 13 -------------
6 files changed, 70 deletions(-)
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportDatabaseConfigurationExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportDatabaseConfigurationExecutorTest.java
index bdae97939dd..b51b00a9b21 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportDatabaseConfigurationExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportDatabaseConfigurationExecutorTest.java
@@ -61,13 +61,6 @@ class ExportDatabaseConfigurationExecutorTest {
private final ShardingSphereDatabase database =
mock(ShardingSphereDatabase.class, RETURNS_DEEP_STUBS);
- @Test
- void assertGetColumns() {
- Collection<String> columns = new
ExportDatabaseConfigurationExecutor().getColumnNames();
- assertThat(columns.size(), is(1));
- assertThat(columns.iterator().next(), is("result"));
- }
-
@Test
void assertExecute() {
when(database.getName()).thenReturn("normal_db");
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportMetaDataExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportMetaDataExecutorTest.java
index f01bc82cec3..a1caeb251eb 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportMetaDataExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportMetaDataExecutorTest.java
@@ -71,7 +71,6 @@ import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Map.Entry;
@@ -110,16 +109,6 @@ class ExportMetaDataExecutorTest {
when(database.getProtocolType()).thenReturn(TypedSPILoader.getService(DatabaseType.class,
"FIXTURE"));
}
- @Test
- void assertGetColumns() {
- Collection<String> columns = new
ExportMetaDataExecutor().getColumnNames();
- assertThat(columns.size(), is(3));
- Iterator<String> columnIterator = columns.iterator();
- assertThat(columnIterator.next(), is("id"));
- assertThat(columnIterator.next(), is("create_time"));
- assertThat(columnIterator.next(), is("cluster_info"));
- }
-
@Test
void assertExecuteWithEmptyMetaData() {
ContextManager contextManager = mockEmptyContextManager();
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportStorageNodesExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportStorageNodesExecutorTest.java
index 6f5b87c3757..8599dc83226 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportStorageNodesExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportStorageNodesExecutorTest.java
@@ -61,7 +61,6 @@ import java.io.IOException;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Objects;
@@ -87,16 +86,6 @@ class ExportStorageNodesExecutorTest {
when(database.getProtocolType()).thenReturn(TypedSPILoader.getService(DatabaseType.class,
"FIXTURE"));
}
- @Test
- void assertGetColumns() {
- Collection<String> columns = new
ExportStorageNodesExecutor().getColumnNames();
- assertThat(columns.size(), is(3));
- Iterator<String> columnIterator = columns.iterator();
- assertThat(columnIterator.next(), is("id"));
- assertThat(columnIterator.next(), is("create_time"));
- assertThat(columnIterator.next(), is("storage_nodes"));
- }
-
@Test
void assertExecuteWithWrongDatabaseName() {
ContextManager contextManager = mockEmptyContextManager();
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowComputeNodeInfoExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowComputeNodeInfoExecutorTest.java
index 22956b5625e..af5b8003d1a 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowComputeNodeInfoExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowComputeNodeInfoExecutorTest.java
@@ -28,7 +28,6 @@ import
org.apache.shardingsphere.mode.repository.standalone.StandalonePersistRep
import org.junit.jupiter.api.Test;
import java.util.Collection;
-import java.util.Iterator;
import java.util.Properties;
import static org.hamcrest.CoreMatchers.is;
@@ -39,22 +38,6 @@ import static org.mockito.Mockito.when;
class ShowComputeNodeInfoExecutorTest {
- @Test
- void assertGetColumns() {
- ShowComputeNodeInfoExecutor executor = new
ShowComputeNodeInfoExecutor();
- Collection<String> actual = executor.getColumnNames();
- assertThat(actual.size(), is(8));
- Iterator<String> iterator = actual.iterator();
- assertThat(iterator.next(), is("instance_id"));
- assertThat(iterator.next(), is("host"));
- assertThat(iterator.next(), is("port"));
- assertThat(iterator.next(), is("status"));
- assertThat(iterator.next(), is("mode_type"));
- assertThat(iterator.next(), is("worker_id"));
- assertThat(iterator.next(), is("labels"));
- assertThat(iterator.next(), is("version"));
- }
-
@Test
void assertExecute() {
ShowComputeNodeInfoExecutor executor = new
ShowComputeNodeInfoExecutor();
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableExecutorTest.java
index 54b5701a9ca..57186a09673 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableExecutorTest.java
@@ -32,7 +32,6 @@ import
org.apache.shardingsphere.test.util.PropertiesBuilder.Property;
import org.junit.jupiter.api.Test;
import java.util.Collection;
-import java.util.Iterator;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
@@ -45,16 +44,6 @@ class ShowDistVariableExecutorTest {
private final ContextManager contextManager = mock(ContextManager.class,
RETURNS_DEEP_STUBS);
- @Test
- void assertGetColumns() {
- ShowDistVariableExecutor executor = new ShowDistVariableExecutor();
- Collection<String> columns = executor.getColumnNames();
- assertThat(columns.size(), is(2));
- Iterator<String> iterator = columns.iterator();
- assertThat(iterator.next(), is("variable_name"));
- assertThat(iterator.next(), is("variable_value"));
- }
-
@Test
void assertShowCachedConnections() {
ShowDistVariableExecutor executor = new ShowDistVariableExecutor();
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowStatusFromReadwriteSplittingRulesExecutorTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowStatusFromReadwriteSplittingRulesExecutorTest.java
index cbf005acf18..1ef949293be 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowStatusFromReadwriteSplittingRulesExecutorTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowStatusFromReadwriteSplittingRulesExecutorTest.java
@@ -43,13 +43,10 @@ import org.junit.jupiter.api.extension.ExtendWith;
import java.util.Collection;
import java.util.Collections;
-import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Properties;
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
import static org.mockito.Mockito.mock;
@@ -59,16 +56,6 @@ import static org.mockito.Mockito.when;
@StaticMockSettings(ProxyContext.class)
class ShowStatusFromReadwriteSplittingRulesExecutorTest {
- @Test
- void assertGetColumns() {
- ShowStatusFromReadwriteSplittingRulesExecutor executor = new
ShowStatusFromReadwriteSplittingRulesExecutor();
- Collection<String> columns = executor.getColumnNames();
- assertThat(columns.size(), is(2));
- Iterator<String> iterator = columns.iterator();
- assertThat(iterator.next(), is("storage_unit"));
- assertThat(iterator.next(), is("status"));
- }
-
@Test
void assertGetRowsWithEmptyResult() {
ShowStatusFromReadwriteSplittingRulesExecutor executor = new
ShowStatusFromReadwriteSplittingRulesExecutor();
