This is an automated email from the ASF dual-hosted git repository.

zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 14cfc41fbd6 Add javadoc on AbstractStaticMethodAdvice (#30282)
14cfc41fbd6 is described below

commit 14cfc41fbd6f3e97aba60dc3f2a5cf929d8f5b94
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Feb 25 18:16:36 2024 +0800

    Add javadoc on AbstractStaticMethodAdvice (#30282)
    
    * Revise AgentYamlEngineTest
    
    * Refactor AdviceExecutorFactory
    
    * Add javadoc on AbstractStaticMethodAdvice
---
 .../agent/core/advisor/executor/AdviceExecutorFactory.java             | 2 +-
 .../agent/plugin/core/advice/AbstractInstanceMethodAdvice.java         | 3 +++
 .../agent/plugin/core/advice/AbstractStaticMethodAdvice.java           | 3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/agent/core/src/main/java/org/apache/shardingsphere/agent/core/advisor/executor/AdviceExecutorFactory.java
 
b/agent/core/src/main/java/org/apache/shardingsphere/agent/core/advisor/executor/AdviceExecutorFactory.java
index c915ce3436f..ec92fd3ad9b 100644
--- 
a/agent/core/src/main/java/org/apache/shardingsphere/agent/core/advisor/executor/AdviceExecutorFactory.java
+++ 
b/agent/core/src/main/java/org/apache/shardingsphere/agent/core/advisor/executor/AdviceExecutorFactory.java
@@ -54,7 +54,7 @@ public final class AdviceExecutorFactory {
      * @return found advice executor
      */
     public Optional<AdviceExecutor> findMatchedAdviceExecutor(final 
InDefinedShape methodDescription) {
-        Map<String, Collection<AgentAdvice>> advices = new HashMap<>();
+        Map<String, Collection<AgentAdvice>> advices = new 
HashMap<>(advisorConfig.getAdvisors().size(), 1F);
         for (MethodAdvisorConfiguration each : advisorConfig.getAdvisors()) {
             if (each.getPointcut().matches(methodDescription)) {
                 advices.computeIfAbsent(each.getPluginType(), key -> new 
LinkedList<>());
diff --git 
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractInstanceMethodAdvice.java
 
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractInstanceMethodAdvice.java
index 860e8b5b1c9..11da9c7bad6 100644
--- 
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractInstanceMethodAdvice.java
+++ 
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractInstanceMethodAdvice.java
@@ -21,6 +21,9 @@ import 
org.apache.shardingsphere.agent.api.plugin.AgentPluginEnable;
 import org.apache.shardingsphere.agent.api.advice.type.InstanceMethodAdvice;
 import org.apache.shardingsphere.agent.plugin.core.context.PluginContext;
 
+/**
+ * Abstract instance method advice.
+ */
 public abstract class AbstractInstanceMethodAdvice implements 
InstanceMethodAdvice, AgentPluginEnable {
     
     @Override
diff --git 
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractStaticMethodAdvice.java
 
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractStaticMethodAdvice.java
index c3d9dbae77a..80350378f9c 100644
--- 
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractStaticMethodAdvice.java
+++ 
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/advice/AbstractStaticMethodAdvice.java
@@ -21,6 +21,9 @@ import 
org.apache.shardingsphere.agent.api.plugin.AgentPluginEnable;
 import org.apache.shardingsphere.agent.api.advice.type.StaticMethodAdvice;
 import org.apache.shardingsphere.agent.plugin.core.context.PluginContext;
 
+/**
+ * Abstract static method advice.
+ */
 public abstract class AbstractStaticMethodAdvice implements 
StaticMethodAdvice, AgentPluginEnable {
     
     @Override

Reply via email to