linghengqian opened a new issue, #33:
URL: https://github.com/apache/shardingsphere-plugin/issues/33

   ## Feature Request
   
   **For English only**, other languages will not be accepted.
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot make decision by current information, 
we will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Is your feature request related to a problem?
   
   - Yes, refer to apache/shardingsphere#29588 and apache/shardingsphere#29052 .
   
   ### Describe the feature you would like.
   
   - `com.ecwid.consul:consul-api` has not released a new version for 4 years, 
which has led to issues like https://github.com/Ecwid/consul-api/issues/246 and 
was released in Consul 1.17 .x will be completely unavailable. Issues like 
https://github.com/spring-cloud/spring-cloud-consul/issues/475 are actively 
being moved away from `com.ecwid.consul:consul-api`.
   
   - Issues like https://github.com/Ecwid/consul-api/issues/19 expose that 
`com.ecwid.consul:consul-api` does not encapsulate the watches API at all, 
refer to 
https://developer.hashicorp.com/consul/docs/v1.17.x/dynamic-app-config/watches 
. This resulted in `shardingsphere-cluster-mode-repository-consul` even 
operating the `index` manually, which caused a lot of confusion in further 
maintenance.
   
   - According to an investigation at 
https://github.com/apache/shardingsphere/pull/29588, the Consul integration is 
currently unavailable, again requiring further investigation.
   
   - This issue target is handling two subtasks.
   
     - [ ] Replaces `com.ecwid.consul:consul-api` with 
`com.orbitz.consul:consul-client`. 
       - Although `com.orbitz.consul:consul-client` has been archived, its last 
release is later than `com.ecwid.consul:consul-api`. It also provides an 
encapsulation of the `watches` interface, simplifying the use of `Consul Index` 
handling, which helps align the operations of existing Zookeeper integration 
implementations in ShardingSphere.
       - Although there is a community branch as 
`org.kiwiproject:consul-client`, there is nothing that can be done about 
ShardingSphere considering that 
https://github.com/kiwiproject/consul-client/pull/39 improves the JDK compiled 
version to JDK11.
   
     - [ ] Replaces `com.orbitz.consul:consul-client` with 
`io.vertx:vertx-consul-client`. `io.vertx:vertx-consul-client` is the only Java 
Client for Consul currently being maintained. I don't think we should actively 
encapsulate HttpClient, this kind of thing should be done by a third party.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to