yu199195 commented on a change in pull request #4812: Fix 4805.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4812#discussion_r393685513
##########
File path:
sharding-sql-test/src/main/java/org/apache/shardingsphere/test/sql/loader/SQLCasesLoader.java
##########
@@ -190,7 +193,7 @@ private String getLiteralSQL(final String sql, final
List<?> parameters) {
}
private static Collection<String> getDatabaseTypes(final String
databaseTypes) {
- return Strings.isNullOrEmpty(databaseTypes) ? getALlDatabaseTypes() :
Splitter.on(',').trimResults().splitToList(databaseTypes);
+ return Strings.isNullOrEmpty(databaseTypes) ? getALlDatabaseTypes() :
Lists.newArrayList(Splitter.on(',').trimResults().split(databaseTypes));
Review comment:
1. splitToList retrun readOnly List ,if use add, remove ,can throws
exception.
2. init list No default capacity is specified，so this method is @beta。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
