kimmking commented on a change in pull request #4813: Fix 4783 and 4807.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4813#discussion_r394206457
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/asserts/segment/expression/ExpressionAssert.java
##########
@@ -95,8 +95,7 @@ public static void assertCommonExpression(final
SQLCaseAssertContext assertConte
* @param expected expected subquery expression
*/
public static void assertSubqueryExpression(final SQLCaseAssertContext
assertContext, final SubqueryExpressionSegment actual, final ExpectedSubquery
expected) {
- // TODO assert start index, stop index and sub select statement.
SelectStatementAssert.assertIs(assertContext,
actual.getSubquery().getSelect(), expected.getSelectTestCases());
-// SQLSegmentAssert.assertIs(assertContext, actual, expected);
+ SQLSegmentAssert.assertIs(assertContext, actual, expected);
Review comment:
how to do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
