(shardingsphere) branch master updated: Add null condition value test (#30630)

[duanzhengqiang]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new ef8ea5e74df Add null condition value test (#30630)
ef8ea5e74df is described below

commit ef8ea5e74dfcac447e93d4d2823c88200818a0e1
Author: ZhangCheng <chengzh...@apache.org>
AuthorDate: Mon Mar 25 10:36:51 2024 +0800

    Add null condition value test (#30630)
---
 .../engine/condition/generator/ConditionValueTest.java  | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git 
a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueTest.java
 
b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueTest.java
index 0b6dcb0922f..daf83223e81 100644
--- 
a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueTest.java
+++ 
b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/ConditionValueTest.java
@@ -22,8 +22,10 @@ import 
org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.simple.L
 import 
org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.simple.ParameterMarkerExpressionSegment;
 import org.junit.jupiter.api.Test;
 
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.LinkedList;
+import java.util.List;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -42,7 +44,7 @@ class ConditionValueTest {
     }
     
     @Test
-    void assertGetValueFromLiteralExpressionSegmentOfNullValue() {
+    void assertGetNullValueFromLiteralExpressionSegment() {
         ExpressionSegment expressionSegment = new LiteralExpressionSegment(0, 
0, null);
         ConditionValue conditionValue = new ConditionValue(expressionSegment, 
new LinkedList<>());
         assertFalse(conditionValue.getValue().isPresent());
@@ -61,12 +63,17 @@ class ConditionValueTest {
     }
     
     @Test
-    void assertGetValueFromParameterMarkerSegmentOfNullValue() {
-        ExpressionSegment expressionSegment = new 
ParameterMarkerExpressionSegment(0, 0, 0);
-        ConditionValue conditionValue = new ConditionValue(expressionSegment, 
Collections.singletonList(null));
+    void assertGetNullValueFromParameterMarkerSegment() {
+        List<Object> params = Arrays.asList(1, null);
+        ConditionValue conditionValue = new ConditionValue(new 
ParameterMarkerExpressionSegment(0, 0, 0), params);
+        assertTrue(conditionValue.getValue().isPresent());
+        assertThat(conditionValue.getValue().get(), is(1));
+        assertTrue(conditionValue.getParameterMarkerIndex().isPresent());
+        assertThat(conditionValue.getParameterMarkerIndex().get(), is(0));
+        conditionValue = new ConditionValue(new 
ParameterMarkerExpressionSegment(0, 0, 1), params);
         assertFalse(conditionValue.getValue().isPresent());
         assertTrue(conditionValue.isNull());
         assertTrue(conditionValue.getParameterMarkerIndex().isPresent());
-        assertThat(conditionValue.getParameterMarkerIndex().get(), is(0));
+        assertThat(conditionValue.getParameterMarkerIndex().get(), is(1));
     }
 }