linghengqian opened a new pull request, #30654:
URL: https://github.com/apache/shardingsphere/pull/30654
For #29052.
Changes proposed in this pull request:
- Allow `InlineExpressionParser#handlePlaceHolder` to be an optional
implementation.
- This method is currently only used in several algorithm classes in the
shardingsphere library. Further transformation of the algorithm classes has not
yet been completed. In this case, implementing this method is unnecessary.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]