This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 47048aa858a Remove useless UnsupportedTranslatedSQLException (#30686)
47048aa858a is described below

commit 47048aa858aa3099838f4bd5fdd29d232b48007b
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Mar 29 00:40:39 2024 +0800

    Remove useless UnsupportedTranslatedSQLException (#30686)
    
    * Add typeOffset and errorCode check on ShardingSphereSQLException
    
    * Add typeOffset and errorCode check on KernelSQLException
    
    * Add typeOffset and errorCode check on FeatureSQLException
    
    * Fix test cases
    
    * Remove useless UnsupportedTranslatedSQLException
---
 .../UnsupportedTranslatedDatabaseException.java    |  3 +-
 .../syntax/UnsupportedTranslatedSQLException.java  | 33 ----------------------
 .../sqltranslator/rule/SQLTranslatorRuleTest.java  |  2 +-
 .../rule/fixture/FixtureSQLTranslator.java         |  2 +-
 4 files changed, 3 insertions(+), 37 deletions(-)

diff --git 
a/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedDatabaseException.java
 
b/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/UnsupportedTranslatedDatabaseException.java
similarity index 90%
rename from 
kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedDatabaseException.java
rename to 
kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/UnsupportedTranslatedDatabaseException.java
index 7d25cb4e353..975ddc56503 100644
--- 
a/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedDatabaseException.java
+++ 
b/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/UnsupportedTranslatedDatabaseException.java
@@ -15,11 +15,10 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.sqltranslator.exception.syntax;
+package org.apache.shardingsphere.sqltranslator.exception;
 
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
 import 
org.apache.shardingsphere.infra.exception.core.external.sql.sqlstate.XOpenSQLState;
-import 
org.apache.shardingsphere.sqltranslator.exception.SQLTranslationException;
 
 /**
  * Unsupported translated database exception.
diff --git 
a/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedSQLException.java
 
b/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedSQLException.java
deleted file mode 100644
index ced4a84a658..00000000000
--- 
a/kernel/sql-translator/api/src/main/java/org/apache/shardingsphere/sqltranslator/exception/syntax/UnsupportedTranslatedSQLException.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.sqltranslator.exception.syntax;
-
-import 
org.apache.shardingsphere.infra.exception.core.external.sql.sqlstate.XOpenSQLState;
-import 
org.apache.shardingsphere.sqltranslator.exception.SQLTranslationException;
-
-/**
- * Unsupported translated SQL exception.
- */
-public final class UnsupportedTranslatedSQLException extends 
SQLTranslationException {
-    
-    private static final long serialVersionUID = -1419778194546662319L;
-    
-    public UnsupportedTranslatedSQLException(final String sql) {
-        super(XOpenSQLState.SYNTAX_ERROR, 41, "Translation error, SQL is: %s", 
sql);
-    }
-}
diff --git 
a/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/SQLTranslatorRuleTest.java
 
b/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/SQLTranslatorRuleTest.java
index d9df7e525b5..c78e1f34705 100644
--- 
a/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/SQLTranslatorRuleTest.java
+++ 
b/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/SQLTranslatorRuleTest.java
@@ -24,7 +24,7 @@ import 
org.apache.shardingsphere.infra.session.query.QueryContext;
 import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
 import 
org.apache.shardingsphere.sqltranslator.api.config.SQLTranslatorRuleConfiguration;
 import org.apache.shardingsphere.sqltranslator.context.SQLTranslatorContext;
-import 
org.apache.shardingsphere.sqltranslator.exception.syntax.UnsupportedTranslatedDatabaseException;
+import 
org.apache.shardingsphere.sqltranslator.exception.UnsupportedTranslatedDatabaseException;
 import org.junit.jupiter.api.Test;
 
 import java.util.Collections;
diff --git 
a/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/fixture/FixtureSQLTranslator.java
 
b/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/fixture/FixtureSQLTranslator.java
index d87394b7f4e..afaa187dfd5 100644
--- 
a/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/fixture/FixtureSQLTranslator.java
+++ 
b/kernel/sql-translator/core/src/test/java/org/apache/shardingsphere/sqltranslator/rule/fixture/FixtureSQLTranslator.java
@@ -23,7 +23,7 @@ import 
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
 import org.apache.shardingsphere.infra.metadata.database.rule.RuleMetaData;
 import org.apache.shardingsphere.infra.session.query.QueryContext;
 import org.apache.shardingsphere.sqltranslator.context.SQLTranslatorContext;
-import 
org.apache.shardingsphere.sqltranslator.exception.syntax.UnsupportedTranslatedDatabaseException;
+import 
org.apache.shardingsphere.sqltranslator.exception.UnsupportedTranslatedDatabaseException;
 import org.apache.shardingsphere.sqltranslator.spi.SQLTranslator;
 
 import java.util.List;

Reply via email to