strongduanmu commented on code in PR #30935:
URL: https://github.com/apache/shardingsphere/pull/30935#discussion_r1568285329
##########
kernel/sql-federation/executor/src/main/java/org/apache/shardingsphere/sqlfederation/executor/enumerator/JDBCRowEnumerator.java:
##########
@@ -64,11 +67,16 @@ private boolean moveNext0() throws SQLException {
private void setCurrentRow() throws SQLException {
Object[] rowValues = new Object[metaData.getColumnCount()];
for (int i = 0; i < metaData.getColumnCount(); i++) {
- rowValues[i] = queryResult.getValue(i + 1, Object.class);
+ rowValues[i] = getValue(i);
}
this.currentRow = 1 == metaData.getColumnCount() ? rowValues[0] :
rowValues;
}
+ private Object getValue(final int index) throws SQLException {
Review Comment:
Can you add e2e test for this convert logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
