strongduanmu commented on code in PR #30905:
URL: https://github.com/apache/shardingsphere/pull/30905#discussion_r1573295824
##########
features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/api/config/EncryptRuleConfiguration.java:
##########
@@ -18,26 +18,36 @@
package org.apache.shardingsphere.encrypt.api.config;
import lombok.Getter;
-import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.encrypt.api.config.rule.EncryptTableRuleConfiguration;
+import org.apache.shardingsphere.encrypt.spi.EncryptAlgorithm;
+import org.apache.shardingsphere.encrypt.spi.EncryptAlgorithmMetaData;
import
org.apache.shardingsphere.infra.algorithm.core.config.AlgorithmConfiguration;
import
org.apache.shardingsphere.infra.config.rule.function.EnhancedRuleConfiguration;
import
org.apache.shardingsphere.infra.config.rule.scope.DatabaseRuleConfiguration;
+import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import java.util.Collection;
import java.util.Map;
/**
* Encrypt rule configuration.
*/
-@RequiredArgsConstructor
@Getter
public final class EncryptRuleConfiguration implements
DatabaseRuleConfiguration, EnhancedRuleConfiguration {
private final Collection<EncryptTableRuleConfiguration> tables;
private final Map<String, AlgorithmConfiguration> encryptors;
+ public EncryptRuleConfiguration(final
Collection<EncryptTableRuleConfiguration> tables, final Map<String,
AlgorithmConfiguration> encryptors) {
+ this.tables = tables;
+ this.encryptors = encryptors;
+ for (AlgorithmConfiguration each : this.encryptors.values()) {
Review Comment:
Please remove this, and use local variable.
##########
proxy/bootstrap/src/main/resources/conf/global.yaml:
##########
@@ -21,26 +21,24 @@
#
######################################################################################################
-#mode:
-# type: Cluster
-# repository:
-# type: ZooKeeper
-# props:
-# namespace: governance_ds
-# server-lists: localhost:2181
-# retryIntervalMilliseconds: 500
-# timeToLiveSeconds: 60
-# maxRetries: 3
-# operationTimeoutMilliseconds: 500
-#
-#authority:
-# users:
-# - user: root@%
-# password: root
-# - user: sharding
-# password: sharding
-# privilege:
-# type: ALL_PERMITTED
+mode:
Review Comment:
Please revert this config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
