shubham-j-sde commented on PR #31047: URL: https://github.com/apache/shardingsphere/pull/31047#issuecomment-2081823214
Hey, please help me if I am wrong, but the code seems a bit logically not exact. `AUTOEXTEND_SIZE [=] 'value'` is supported only in InnoDB for ALTER TABLESPACE statement. [link](https://dev.mysql.com/doc/refman/8.0/en/alter-tablespace.html#:~:text=InnoDB%20only%3A%0A%20%20%20%20%5BAUTOEXTEND_SIZE%20%5B%3D%5D%20%27value%27%5D ) Also, I think `ALTER TABLESPACE ts1 ENGINE_ATTRIBUTE` is referring to InnoDB in NDB Cluster, they create `ts1` [here](https://dev.mysql.com/doc/refman/8.0/en/create-tablespace.html#:~:text=CREATE%20TABLESPACE%20statements.-,InnoDB%20Examples,-This%20example%20demonstrates) and use same example ts1 for `ALTER TABLESPACE` page. [For NDB TABLESPACE `ts_1` and `myts` identifiers are used] So, `ENGINE_ATTRIBUTE` should perhaps be added in `alterTablespaceInnodb ` , perhaps in both actually. also it should be [`[jsonAttribute=string_]`](https://github.com/apache/shardingsphere/blob/982b5a8f3e55b2eabf4bf35967ee1aa333c288e3/parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4#L568) I tried the commands on mysql ndb cluster for both InnoDB and NDB Tablespaces. yet to check on shardingsphere though. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
