tristaZero opened a new issue #4885: Parse `Join table` for supporting `Join table` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4885 Content: Parsing `Join table` is first and vital for supporting `Join table` query SQL. Difficulty Rating: ★★★☆☆ ### How to handle this issue? 1.Create `JoinedTableSegment` including `joinSpecificationSegment`, like ``` class joinSpecificationSegment { PredicateSegment Collection<columnSegment> } class JoinedTableSegment { tableSegment joinSpecificationSegment } ``` 2.Add `JoinedTableSegment` to `SelectStatement` 3.Parse `JoinedTableSegment` and `joinSpecificationSegment` by visitXXX() 4.Modify `visitTableReference()` 5.In order to make sure `getAllTables()` in `SelectStatementContext` return correct result, it is needed to move `getTableSegments(result.getValue(), each)` in `XXXDMLVisitor` to `SelectStatementContext` 6.Modify the parsing test results of all the `JOIN` SQLs in `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/select.xml` 7.Run `SQLParserParameterizedTest` well 8.Run `ShardingSQLRewriterParameterizedTest` well
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
