wu979 opened a new issue, #31164:
URL: https://github.com/apache/shardingsphere/issues/31164
## Question
In version 5.5.0, a pre-routing check for mandatory routing was added.
However, in my testing, the RouteContext returned after mandatory routing does
not seem to apply the configured primary key generation strategy or sharding
strategy. Comparing with version 5.2.1, it can be observed that even the lowest
strategy in the ShardingRouteEngineFactory factory is unicast or standard
sharding. However, version 5.5.0 does not enter a loop, and it's unclear
whether ShardingSphereRule is not taking effect or if it's designed this way.
**ShardingSphere 5.2.1 PartialSQLRouteExecutor**
@Override
@SuppressWarnings({"unchecked", "rawtypes"})
public RouteContext route(final ConnectionContext connectionContext,
final QueryContext queryContext, final ShardingSphereDatabase database) {
RouteContext result = new RouteContext();
for (Entry<ShardingSphereRule, SQLRouter> entry :
routers.entrySet()) {
if (result.getRouteUnits().isEmpty()) {
result = entry.getValue().createRouteContext(queryContext,
database, entry.getKey(), props, connectionContext);
} else {
entry.getValue().decorateRouteContext(result, queryContext,
database, entry.getKey(), props, connectionContext);
}
}
if (result.getRouteUnits().isEmpty() && 1 ==
database.getResourceMetaData().getDataSources().size()) {
String singleDataSourceName =
database.getResourceMetaData().getDataSources().keySet().iterator().next();
result.getRouteUnits().add(new RouteUnit(new
RouteMapper(singleDataSourceName, singleDataSourceName),
Collections.emptyList()));
}
return result;
}
**ShardingSphere5.5.0 PartialSQLRouteExecutor**
@Override
@SuppressWarnings({"unchecked", "rawtypes"})
public RouteContext route(final ConnectionContext connectionContext,
final QueryContext queryContext, final RuleMetaData globalRuleMetaData, final
ShardingSphereDatabase database) {
RouteContext result = new RouteContext();
Optional<String> dataSourceName =
findDataSourceByHint(queryContext.getHintValueContext(),
database.getResourceMetaData().getStorageUnits());
if (dataSourceName.isPresent()) {
result.getRouteUnits().add(new RouteUnit(new
RouteMapper(dataSourceName.get(), dataSourceName.get()),
Collections.emptyList()));
return result;
}
for (Entry<ShardingSphereRule, SQLRouter> entry :
routers.entrySet()) {
if (result.getRouteUnits().isEmpty()) {
result = entry.getValue().createRouteContext(queryContext,
globalRuleMetaData, database, entry.getKey(), props, connectionContext);
} else {
entry.getValue().decorateRouteContext(result, queryContext,
database, entry.getKey(), props, connectionContext);
}
}
if (result.getRouteUnits().isEmpty() && 1 ==
database.getResourceMetaData().getStorageUnits().size()) {
String singleDataSourceName =
database.getResourceMetaData().getStorageUnits().keySet().iterator().next();
result.getRouteUnits().add(new RouteUnit(new
RouteMapper(singleDataSourceName, singleDataSourceName),
Collections.emptyList()));
}
return result;
}
**Sharding.yaml**
dataSources:
user:
driverClassName: com.mysql.cj.jdbc.Driver
dataSourceClassName: com.zaxxer.hikari.HikariDataSource
jdbcUrl:
jdbc:mysql://127.0.0.1:3306/user?useSSL=false&characterEncoding=utf-8
username: root
password: root
hikari:
auto-commit: true
connection-test-query: SELECT 1
connection-timeout: 500000
idle-timeout: 300000
max-lifetime: 900000
maximum-pool-size: 30
minimum-idle: 10
pool-name: HikariCP
validation-timeout: 1000
rules:
- !SHARDING
tables:
t_user_info:
actualDataNodes: user.t_user_info_${0..1}
tableStrategy:
standard:
shardingColumn: unique_id
shardingAlgorithmName: t_user_info_inline
defaultDatabaseStrategy:
hint:
shardingAlgorithmName: dynamic-hint
defaultKeyGenerateStrategy:
column: unique_id
keyGeneratorName: snowflake
shardingAlgorithms:
t_user_info_inline:
type: INLINE
props:
algorithm-expression: t_user_info_${unique_id % 2}
dynamic-hint:
type: DYNAMIC-HINT
keyGenerators:
snowflake:
type: SNOWFLAKE
props:
sql-show: true
**ShardingHintRoutingAlgorithm**
public final class ShardingHintRoutingAlgorithm implements
HintShardingAlgorithm<Comparable<?>> {
private final Environment environment;
public ShardingHintRoutingAlgorithm() {
environment = BeanHolder.getBean(Environment.class);
}
@Override
public Collection<String> doSharding(Collection<String>
availableTargetNames, HintShardingValue<Comparable<?>> shardingValue) {
return
Lists.newArrayList(ShardingRoutingDataSourceHolder.getSharding());
}
@Override
public void init(Properties props) {
environment.resolvePlaceholders("");
}
@Override
public String getType() {
return "DYNAMIC-HINT";
}
}
Enter AOP via annotations, and enforce routing with HintManager based on
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
