Kiritsgu commented on issue #30974: URL: https://github.com/apache/shardingsphere/issues/30974#issuecomment-2141393048
@strongduanmu Hi, I found that this issue has already been resolved in a previous PR [#31133](https://github.com/apache/shardingsphere/pull/31133). The existing G4 rule for CALL should support any CALL functionName(functionParameter) statement: `call : CALL (owner DOT_)? identifier (LP_ (expr (COMMA_ expr)*)? RP_)? ;` Out of the four examples in this issue, the following two can be executed correctly. `CALL sys.ps_setup_enable_consumer('history_long');` `CALL sys.ps_setup_reset_to_default(TRUE);` The third example cannot be executed correctly because the variable 'group' is a reserved keyword in MySQL. `CALL mysql.sp_set_firewall_group_mode(group, mode); ` However, this should be considered an instance error in the official documentation. The 'group' here should refer to a user-defined group (which should be enclosed in quotes), and the subsequent example sentences also support this point. <img width="1214" alt="image" src="https://github.com/apache/shardingsphere/assets/96120388/d11471bd-d292-4fd3-b24a-4a930adfd55f";> The last example cannot be executed due to a syntax error in the official documentation example itself (missing a quotation mark after ‘mygroup’). `CALL sp_migrate_firewall_user_to_group('fwuser@localhost', 'mygroup);` <img width="1135" alt="image" src="https://github.com/apache/shardingsphere/assets/96120388/88eedc51-184e-4e81-aac8-018f2195d6a5";> In summary, this issue has been resolved, and I believe it can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
