(shardingsphere) branch master updated: Remove useless ShardingSpherePreparedStatement.parameterSets (#31542)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1473942c5d9 Remove useless 
ShardingSpherePreparedStatement.parameterSets (#31542)
1473942c5d9 is described below

commit 1473942c5d9ab208cc1ab72aa444c14b27cc0abd
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Jun 3 00:22:44 2024 +0800

    Remove useless ShardingSpherePreparedStatement.parameterSets (#31542)
---
 .../jdbc/core/statement/ShardingSpherePreparedStatement.java  | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git 
a/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
 
b/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
index 1f8d6949915..3b45b7bc110 100644
--- 
a/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
+++ 
b/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
@@ -103,8 +103,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
     
     private final List<PreparedStatement> statements;
     
-    private final List<List<Object>> parameterSets;
-    
     private final SQLStatementContext sqlStatementContext;
     
     private final String databaseName;
@@ -172,7 +170,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
         hintValueContext = SQLHintUtils.extractHint(sql);
         this.sql = SQLHintUtils.removeHint(sql);
         statements = new ArrayList<>();
-        parameterSets = new ArrayList<>();
         SQLParserRule sqlParserRule = 
metaData.getGlobalRuleMetaData().getSingleRule(SQLParserRule.class);
         SQLParserEngine sqlParserEngine = 
sqlParserRule.getSQLParserEngine(metaData.getDatabase(connection.getDatabaseName()).getProtocolType());
         SQLStatement sqlStatement = sqlParserEngine.parse(this.sql, true);
@@ -216,7 +213,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
             for (Statement each : executor.getStatements()) {
                 statements.add((PreparedStatement) each);
             }
-            parameterSets.addAll(executor.getParameterSets());
             return currentResultSet;
             // CHECKSTYLE:OFF
         } catch (final RuntimeException ex) {
@@ -236,9 +232,7 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
     }
     
     private void resetParameters() throws SQLException {
-        parameterSets.clear();
-        parameterSets.add(getParameters());
-        replaySetParameter(statements, parameterSets);
+        replaySetParameter(statements, 
Collections.singletonList(getParameters()));
     }
     
     private DriverExecutionPrepareEngine<JDBCExecutionUnit, Connection> 
createDriverExecutionPrepareEngine(final ShardingSphereDatabase database) {
@@ -263,7 +257,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
             for (Statement each : executor.getStatements()) {
                 statements.add((PreparedStatement) each);
             }
-            parameterSets.addAll(executor.getParameterSets());
             findGeneratedKey().ifPresent(optional -> 
generatedValues.addAll(optional.getGeneratedValues()));
             return result;
             // CHECKSTYLE:OFF
@@ -292,7 +285,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
             for (Statement each : executor.getStatements()) {
                 statements.add((PreparedStatement) each);
             }
-            parameterSets.addAll(executor.getParameterSets());
             findGeneratedKey().ifPresent(optional -> 
generatedValues.addAll(optional.getGeneratedValues()));
             return result;
             // CHECKSTYLE:OFF
@@ -393,7 +385,6 @@ public final class ShardingSpherePreparedStatement extends 
AbstractPreparedState
     private void clearPrevious() {
         currentResultSet = null;
         statements.clear();
-        parameterSets.clear();
         generatedValues.clear();
         executor.clear();
     }