(shardingsphere) branch master updated: Refactor BroadcastSQLRouter and add TODO (#31627)

[sunnianjun]

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ae56ccc1dc Refactor BroadcastSQLRouter and add TODO (#31627)
2ae56ccc1dc is described below

commit 2ae56ccc1dc157be3d37c34d3eabc243fbac72c4
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Fri Jun 7 18:31:17 2024 +0800

    Refactor BroadcastSQLRouter and add TODO (#31627)
---
 .../apache/shardingsphere/broadcast/route/BroadcastSQLRouter.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/features/broadcast/core/src/main/java/org/apache/shardingsphere/broadcast/route/BroadcastSQLRouter.java
 
b/features/broadcast/core/src/main/java/org/apache/shardingsphere/broadcast/route/BroadcastSQLRouter.java
index 1317360ebf3..07c29c262b9 100644
--- 
a/features/broadcast/core/src/main/java/org/apache/shardingsphere/broadcast/route/BroadcastSQLRouter.java
+++ 
b/features/broadcast/core/src/main/java/org/apache/shardingsphere/broadcast/route/BroadcastSQLRouter.java
@@ -108,12 +108,11 @@ public final class BroadcastSQLRouter implements 
SQLRouter<BroadcastRule> {
             routeToAllDatabase(routeContext, broadcastRule);
             return;
         }
+        // TODO BEGIN extract db route logic to common database router, eg: 
DCL in instance route @duanzhengqiang
         if (sqlStatement instanceof CreateTablespaceStatement || sqlStatement 
instanceof AlterTablespaceStatement || sqlStatement instanceof 
DropTablespaceStatement) {
-            if 
(broadcastRule.isAllBroadcastTables(sqlStatementContext.getTablesContext().getTableNames()))
 {
-                routeToAllDatabaseInstance(routeContext, database, 
broadcastRule);
-            }
-            return;
+            routeToAllDatabaseInstance(routeContext, database, broadcastRule);
         }
+        // TODO END extract db route logic to common database router, eg: DCL 
in instance route
         Collection<String> tableNames = sqlStatementContext instanceof 
TableAvailable ? getTableNames((TableAvailable) sqlStatementContext) : 
sqlStatementContext.getTablesContext().getTableNames();
         if (broadcastRule.isAllBroadcastTables(tableNames)) {
             routeToAllDatabaseInstance(routeContext, database, broadcastRule);