(shardingsphere) branch master updated: Refactor ColumnValueReaderEngine (#31879)

[duanzhengqiang]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 0748ea50045 Refactor ColumnValueReaderEngine (#31879)
0748ea50045 is described below

commit 0748ea50045684a8614abadf37c27983221681fa
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Thu Jun 27 08:29:00 2024 +0800

    Refactor ColumnValueReaderEngine (#31879)
---
 .../inventory/column/ColumnValueReaderEngine.java  | 24 ++++------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
index 33efde4677f..4c293d371c2 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
@@ -65,29 +65,13 @@ public final class ColumnValueReaderEngine {
             case Types.BOOLEAN:
                 return resultSet.getBoolean(columnIndex);
             case Types.TINYINT:
-                if (isSigned(metaData, columnIndex)) {
-                    return resultSet.getByte(columnIndex);
-                } else {
-                    return resultSet.getShort(columnIndex);
-                }
+                return isSigned(metaData, columnIndex) ? 
resultSet.getByte(columnIndex) : resultSet.getShort(columnIndex);
             case Types.SMALLINT:
-                if (isSigned(metaData, columnIndex)) {
-                    return resultSet.getShort(columnIndex);
-                } else {
-                    return resultSet.getInt(columnIndex);
-                }
+                return isSigned(metaData, columnIndex) ? 
resultSet.getShort(columnIndex) : resultSet.getInt(columnIndex);
             case Types.INTEGER:
-                if (isSigned(metaData, columnIndex)) {
-                    return resultSet.getInt(columnIndex);
-                } else {
-                    return resultSet.getLong(columnIndex);
-                }
+                return isSigned(metaData, columnIndex) ? 
resultSet.getInt(columnIndex) : resultSet.getLong(columnIndex);
             case Types.BIGINT:
-                if (isSigned(metaData, columnIndex)) {
-                    return resultSet.getLong(columnIndex);
-                } else {
-                    return resultSet.getBigDecimal(columnIndex);
-                }
+                return isSigned(metaData, columnIndex) ? 
Long.valueOf(resultSet.getLong(columnIndex)) : 
resultSet.getBigDecimal(columnIndex);
             case Types.NUMERIC:
             case Types.DECIMAL:
                 return resultSet.getBigDecimal(columnIndex);