tristaZero commented on a change in pull request #4916: add tableReferences in
selectStatement
URL:
https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r398298231
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/select-join.xml
##########
@@ -48,8 +48,8 @@
<simple-table name="t_order" start-index="27" stop-index="33" />
<simple-table name="t_order_item" start-index="40" stop-index="51"
/>
<!-- FIXME should not has table segment for owner -->
- <simple-table name="t_order" start-index="56" stop-index="62" />
- <simple-table name="t_order_item" start-index="75" stop-index="86"
/>
Review comment:
? I guess you missed this comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
