This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e4b14c8809a Remove useless ParameterMarkerSegmentBinder (#32087)
e4b14c8809a is described below

commit e4b14c8809a4442a820bb37e3a98088a6557a1c4
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jul 12 23:59:35 2024 +0800

    Remove useless ParameterMarkerSegmentBinder (#32087)
---
 .../from/impl/SubqueryTableSegmentBinder.java      |  2 +-
 .../ParameterMarkerExpressionSegmentBinder.java    |  2 +-
 .../parameter/ParameterMarkerSegmentBinder.java    | 59 ----------------------
 3 files changed, 2 insertions(+), 61 deletions(-)

diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/from/impl/SubqueryTableSegmentBinder.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/from/impl/SubqueryTableSegmentBinder.java
index 05ec6f39655..b4251865dd6 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/from/impl/SubqueryTableSegmentBinder.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/from/impl/SubqueryTableSegmentBinder.java
@@ -23,7 +23,7 @@ import lombok.NoArgsConstructor;
 import 
org.apache.shardingsphere.infra.binder.context.segment.select.projection.util.ProjectionUtils;
 import 
org.apache.shardingsphere.infra.binder.segment.from.SimpleTableSegmentBinderContext;
 import 
org.apache.shardingsphere.infra.binder.segment.from.TableSegmentBinderContext;
-import 
org.apache.shardingsphere.infra.binder.segment.parameter.impl.ParameterMarkerExpressionSegmentBinder;
+import 
org.apache.shardingsphere.infra.binder.segment.parameter.ParameterMarkerExpressionSegmentBinder;
 import 
org.apache.shardingsphere.infra.binder.statement.SQLStatementBinderContext;
 import 
org.apache.shardingsphere.infra.binder.statement.dml.SelectStatementBinder;
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/impl/ParameterMarkerExpressionSegmentBinder.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerExpressionSegmentBinder.java
similarity index 99%
rename from 
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/impl/ParameterMarkerExpressionSegmentBinder.java
rename to 
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerExpressionSegmentBinder.java
index 9ee4545d85a..4a5e94f9af1 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/impl/ParameterMarkerExpressionSegmentBinder.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerExpressionSegmentBinder.java
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.infra.binder.segment.parameter.impl;
+package org.apache.shardingsphere.infra.binder.segment.parameter;
 
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerSegmentBinder.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerSegmentBinder.java
deleted file mode 100644
index e696d63af4f..00000000000
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/parameter/ParameterMarkerSegmentBinder.java
+++ /dev/null
@@ -1,59 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.infra.binder.segment.parameter;
-
-import lombok.AccessLevel;
-import lombok.NoArgsConstructor;
-import 
org.apache.shardingsphere.infra.binder.segment.parameter.impl.ParameterMarkerExpressionSegmentBinder;
-import 
org.apache.shardingsphere.sql.parser.statement.core.segment.dml.expr.simple.ParameterMarkerExpressionSegment;
-import 
org.apache.shardingsphere.sql.parser.statement.core.segment.generic.ParameterMarkerSegment;
-import 
org.apache.shardingsphere.sql.parser.statement.core.segment.generic.bound.ColumnSegmentBoundInfo;
-
-import java.util.Collection;
-import java.util.LinkedList;
-import java.util.Map;
-
-/**
- * Parameter marker segment binder.
- */
-@NoArgsConstructor(access = AccessLevel.PRIVATE)
-public final class ParameterMarkerSegmentBinder {
-    
-    /**
-     * Bind parameter marker segment.
-     *
-     * @param parameterMarkerSegments parameter marker segments
-     * @param parameterMarkerSegmentBoundInfos parameter marker segment bound 
infos
-     * @return bound parameter marker segment
-     */
-    public static Collection<ParameterMarkerSegment> bind(final 
Collection<ParameterMarkerSegment> parameterMarkerSegments,
-                                                          final 
Map<ParameterMarkerSegment, ColumnSegmentBoundInfo> 
parameterMarkerSegmentBoundInfos) {
-        Collection<ParameterMarkerSegment> result = new LinkedList<>();
-        parameterMarkerSegments.forEach(each -> result.add(bind(each, 
parameterMarkerSegmentBoundInfos)));
-        return result;
-    }
-    
-    private static ParameterMarkerSegment bind(final ParameterMarkerSegment 
parameterMarkerSegment,
-                                               final 
Map<ParameterMarkerSegment, ColumnSegmentBoundInfo> 
parameterMarkerSegmentBoundInfos) {
-        if (parameterMarkerSegment instanceof 
ParameterMarkerExpressionSegment) {
-            return 
ParameterMarkerExpressionSegmentBinder.bind((ParameterMarkerExpressionSegment) 
parameterMarkerSegment, parameterMarkerSegmentBoundInfos);
-        }
-        // TODO support more ParameterMarkerSegment bind
-        return parameterMarkerSegment;
-    }
-}

Reply via email to