This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 0e13043daf7 Refactor InsertStatementContext (#32103)
0e13043daf7 is described below

commit 0e13043daf74dc5c93dce216b986338b22d02bcd
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Jul 14 22:24:23 2024 +0800

    Refactor InsertStatementContext (#32103)
---
 .../statement/dml/InsertStatementContext.java      | 30 +++++++++++-----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/dml/InsertStatementContext.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/dml/InsertStatementContext.java
index e3e944ec15b..2dff59524bf 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/dml/InsertStatementContext.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/dml/InsertStatementContext.java
@@ -102,21 +102,6 @@ public final class InsertStatementContext extends 
CommonSQLStatementContext impl
         generatedKeyContext = new GeneratedKeyContextEngine(sqlStatement, 
schema).createGenerateKeyContext(insertColumnNames, insertValueContexts, 
params).orElse(null);
     }
     
-    private ShardingSphereSchema getSchema(final ShardingSphereMetaData 
metaData, final String currentDatabaseName) {
-        String databaseName = 
tablesContext.getDatabaseName().orElse(currentDatabaseName);
-        ShardingSpherePreconditions.checkNotNull(databaseName, 
NoDatabaseSelectedException::new);
-        ShardingSphereDatabase database = metaData.getDatabase(databaseName);
-        ShardingSpherePreconditions.checkNotNull(database, () -> new 
UnknownDatabaseException(databaseName));
-        String defaultSchema = new 
DatabaseTypeRegistry(getDatabaseType()).getDefaultSchemaName(databaseName);
-        return 
tablesContext.getSchemaName().map(database::getSchema).orElseGet(() -> 
database.getSchema(defaultSchema));
-    }
-    
-    private Collection<SimpleTableSegment> getAllSimpleTableSegments() {
-        TableExtractor tableExtractor = new TableExtractor();
-        tableExtractor.extractTablesFromInsert(getSqlStatement());
-        return tableExtractor.getRewriteTables();
-    }
-    
     private List<InsertValueContext> getInsertValueContexts(final List<Object> 
params, final AtomicInteger paramsOffset, final List<List<ExpressionSegment>> 
valueExpressions) {
         List<InsertValueContext> result = new LinkedList<>();
         for (Collection<ExpressionSegment> each : valueExpressions) {
@@ -151,6 +136,21 @@ public final class InsertStatementContext extends 
CommonSQLStatementContext impl
         return Optional.of(onDuplicateUpdateContext);
     }
     
+    private Collection<SimpleTableSegment> getAllSimpleTableSegments() {
+        TableExtractor tableExtractor = new TableExtractor();
+        tableExtractor.extractTablesFromInsert(getSqlStatement());
+        return tableExtractor.getRewriteTables();
+    }
+    
+    private ShardingSphereSchema getSchema(final ShardingSphereMetaData 
metaData, final String currentDatabaseName) {
+        String databaseName = 
tablesContext.getDatabaseName().orElse(currentDatabaseName);
+        ShardingSpherePreconditions.checkNotNull(databaseName, 
NoDatabaseSelectedException::new);
+        ShardingSphereDatabase database = metaData.getDatabase(databaseName);
+        ShardingSpherePreconditions.checkNotNull(database, () -> new 
UnknownDatabaseException(databaseName));
+        String defaultSchema = new 
DatabaseTypeRegistry(getDatabaseType()).getDefaultSchemaName(databaseName);
+        return 
tablesContext.getSchemaName().map(database::getSchema).orElseGet(() -> 
database.getSchema(defaultSchema));
+    }
+    
     /**
      * Get column names for descending order.
      *

Reply via email to