codecov-io commented on issue #4945: make key-generator as a spring bean on 
spring namespace.
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604251543
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=h1)
 Report
   > Merging 
[#4945](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/61378239e8a8ec7356677b7aff287b772c45c68f&el=desc)
 will **decrease** coverage by `0.07%`.
   > The diff coverage is `78.94%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4945      +/-   ##
   ============================================
   - Coverage     54.54%   54.47%   -0.08%     
   - Complexity      440      442       +2     
   ============================================
     Files          1136     1141       +5     
     Lines         20448    20482      +34     
     Branches       3758     3763       +5     
   ============================================
   + Hits          11154    11158       +4     
   - Misses         8586     8617      +31     
   + Partials        708      707       -1     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=tree)
 | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh)
 | `79.57% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh)
 | `84.09% <50.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...namespace/factorybean/KeyGeneratorFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdG9yRmFjdG9yeUJlYW4uamF2YQ==)
 | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...api/config/sharding/KeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9zaGFyZGluZy9LZXlHZW5lcmF0b3JDb25maWd1cmF0aW9uLmphdmE=)
 | `100.00% <100.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | 
[.../swapper/KeyGeneratorConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...space/parser/KeyGeneratorBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0tleUdlbmVyYXRvckJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=)
 | `100.00% <100.00%> (+18.18%)` | `1.00 <0.00> (ø)` | |
   | 
[.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...sql/parser/mysql/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxETUxWaXNpdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...sql/parser/sql/segment/dml/TableFactorSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvVGFibGVGYWN0b3JTZWdtZW50LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[.../parser/sql/segment/dml/TableReferenceSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvVGFibGVSZWZlcmVuY2VTZWdtZW50LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [3 
more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=footer).
 Last update 
[6137823...3df4a41](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to