This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 66cedc247fa Rename MySQLBinlogDataHandler (#32551)
66cedc247fa is described below

commit 66cedc247fa2470a6006391d5105aaf8cb6139b6
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Aug 16 12:35:11 2024 +0800

    Rename MySQLBinlogDataHandler (#32551)
    
    * Rename MySQLBinlogBinaryStringHandler
    
    * Rename MySQLBinlogDataHandler
---
 .../mysql/ingest/dumper/MySQLIncrementalDumper.java        | 10 +++++-----
 ...logDataTypeHandler.java => MySQLBinlogDataHandler.java} | 14 +++++++-------
 ...ypeHandler.java => MySQLBinlogBinaryStringHandler.java} | 10 +++++-----
 .../type/unsigned/MySQLBinlogUnsignedNumberHandler.java    |  6 +++---
 4 files changed, 20 insertions(+), 20 deletions(-)

diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/MySQLIncrementalDumper.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/MySQLIncrementalDumper.java
index 53a1fb597b1..0487b674c8d 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/MySQLIncrementalDumper.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/MySQLIncrementalDumper.java
@@ -40,7 +40,7 @@ import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.binlog.event.UpdateR
 import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.binlog.event.WriteRowsEvent;
 import org.apache.shardingsphere.data.pipeline.mysql.ingest.client.ConnectInfo;
 import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.client.MySQLBinlogClient;
-import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type.MySQLBinlogDataTypeHandler;
+import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type.MySQLBinlogDataHandler;
 import org.apache.shardingsphere.infra.annotation.HighFrequencyInvocation;
 import 
org.apache.shardingsphere.infra.database.core.connector.ConnectionProperties;
 import 
org.apache.shardingsphere.infra.database.core.connector.ConnectionPropertiesParser;
@@ -151,7 +151,7 @@ public final class MySQLIncrementalDumper extends 
AbstractPipelineLifecycleRunna
             DataRecord dataRecord = 
createDataRecord(PipelineSQLOperationType.INSERT, event, each.length);
             for (int i = 0; i < each.length; i++) {
                 PipelineColumnMetaData columnMetaData = 
tableMetaData.getColumnMetaData(i + 1);
-                dataRecord.addColumn(new Column(columnMetaData.getName(), 
MySQLBinlogDataTypeHandler.handle(columnMetaData, each[i]), true, 
columnMetaData.isUniqueKey()));
+                dataRecord.addColumn(new Column(columnMetaData.getName(), 
MySQLBinlogDataHandler.handle(columnMetaData, each[i]), true, 
columnMetaData.isUniqueKey()));
             }
             result.add(dataRecord);
         }
@@ -166,8 +166,8 @@ public final class MySQLIncrementalDumper extends 
AbstractPipelineLifecycleRunna
             DataRecord dataRecord = 
createDataRecord(PipelineSQLOperationType.UPDATE, event, beforeValues.length);
             for (int j = 0; j < beforeValues.length; j++) {
                 PipelineColumnMetaData columnMetaData = 
tableMetaData.getColumnMetaData(j + 1);
-                Serializable oldValue = 
MySQLBinlogDataTypeHandler.handle(columnMetaData, beforeValues[j]);
-                Serializable newValue = 
MySQLBinlogDataTypeHandler.handle(columnMetaData, afterValues[j]);
+                Serializable oldValue = 
MySQLBinlogDataHandler.handle(columnMetaData, beforeValues[j]);
+                Serializable newValue = 
MySQLBinlogDataHandler.handle(columnMetaData, afterValues[j]);
                 boolean updated = !Objects.deepEquals(newValue, oldValue);
                 dataRecord.addColumn(new Column(columnMetaData.getName(), 
oldValue, newValue, updated, columnMetaData.isUniqueKey()));
             }
@@ -182,7 +182,7 @@ public final class MySQLIncrementalDumper extends 
AbstractPipelineLifecycleRunna
             DataRecord dataRecord = 
createDataRecord(PipelineSQLOperationType.DELETE, event, each.length);
             for (int i = 0, length = each.length; i < length; i++) {
                 PipelineColumnMetaData columnMetaData = 
tableMetaData.getColumnMetaData(i + 1);
-                dataRecord.addColumn(new Column(columnMetaData.getName(), 
MySQLBinlogDataTypeHandler.handle(columnMetaData, each[i]), null, true, 
columnMetaData.isUniqueKey()));
+                dataRecord.addColumn(new Column(columnMetaData.getName(), 
MySQLBinlogDataHandler.handle(columnMetaData, each[i]), null, true, 
columnMetaData.isUniqueKey()));
             }
             result.add(dataRecord);
         }
diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataTypeHandler.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataHandler.java
similarity index 85%
rename from 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataTypeHandler.java
rename to 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataHandler.java
index d40ac63cc1b..b2c986a4253 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataTypeHandler.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/MySQLBinlogDataHandler.java
@@ -19,7 +19,7 @@ package 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type;
 
 import lombok.NoArgsConstructor;
 import 
org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineColumnMetaData;
-import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type.binary.MySQLBinlogBinaryDataTypeHandler;
+import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type.binary.MySQLBinlogBinaryStringHandler;
 import 
org.apache.shardingsphere.data.pipeline.mysql.ingest.dumper.type.unsigned.MySQLBinlogUnsignedNumberHandlerEngine;
 import 
org.apache.shardingsphere.db.protocol.mysql.packet.binlog.row.column.value.string.MySQLBinaryString;
 
@@ -27,24 +27,24 @@ import java.io.Serializable;
 import java.util.Optional;
 
 /**
- * MySQL binlog data type handler.
+ * MySQL binlog data handler.
  */
 @NoArgsConstructor(access = lombok.AccessLevel.PRIVATE)
-public final class MySQLBinlogDataTypeHandler {
+public final class MySQLBinlogDataHandler {
     
     /**
-     * Handle column value.
+     * Handle data value.
      *
      * @param columnMetaData column meta data
-     * @param value column value
-     * @return handled column value
+     * @param value to be handled value
+     * @return handled value
      */
     public static Serializable handle(final PipelineColumnMetaData 
columnMetaData, final Serializable value) {
         if (null == value) {
             return null;
         }
         if (value instanceof MySQLBinaryString) {
-            return MySQLBinlogBinaryDataTypeHandler.handle(columnMetaData, 
value);
+            return MySQLBinlogBinaryStringHandler.handle(columnMetaData, 
value);
         }
         Optional<Serializable> result = 
MySQLBinlogUnsignedNumberHandlerEngine.handle(columnMetaData, value);
         return result.orElse(value);
diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryDataTypeHandler.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryStringHandler.java
similarity index 89%
rename from 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryDataTypeHandler.java
rename to 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryStringHandler.java
index 422f473901f..83d16e2c692 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryDataTypeHandler.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/binary/MySQLBinlogBinaryStringHandler.java
@@ -26,17 +26,17 @@ import java.io.Serializable;
 import java.nio.charset.Charset;
 
 /**
- * MySQL binlog binary data type handler.
+ * MySQL binlog binary string handler.
  */
 @NoArgsConstructor(access = lombok.AccessLevel.PRIVATE)
-public final class MySQLBinlogBinaryDataTypeHandler {
+public final class MySQLBinlogBinaryStringHandler {
     
     /**
-     * Handle column value.
+     * Handle binary string value.
      *
      * @param columnMetaData column meta data
-     * @param value column value
-     * @return handled column value
+     * @param value to be handled value
+     * @return handled value
      */
     public static Serializable handle(final PipelineColumnMetaData 
columnMetaData, final Serializable value) {
         return PipelineJdbcUtils.isBinaryColumn(columnMetaData.getDataType()) 
? ((MySQLBinaryString) value).getBytes() : new String(((MySQLBinaryString) 
value).getBytes(), Charset.defaultCharset());
diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/unsigned/MySQLBinlogUnsignedNumberHandler.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/unsigned/MySQLBinlogUnsignedNumberHandler.java
index 0978b764414..c730195d568 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/unsigned/MySQLBinlogUnsignedNumberHandler.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/dumper/type/unsigned/MySQLBinlogUnsignedNumberHandler.java
@@ -25,10 +25,10 @@ import java.io.Serializable;
 public interface MySQLBinlogUnsignedNumberHandler {
     
     /**
-     * Handle column value.
+     * Handle unsigned number value.
      *
-     * @param value column value
-     * @return handled column value
+     * @param value to be handled value
+     * @return handled value
      */
     Serializable handle(Serializable value);
 }

Reply via email to