This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new ac1f7e8a5b8 Rename InventoryColumnValueReaderEngine (#32555)
ac1f7e8a5b8 is described below

commit ac1f7e8a5b88622a3ba5e2f7d0b99f2e32248fd1
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Aug 16 14:03:33 2024 +0800

    Rename InventoryColumnValueReaderEngine (#32555)
---
 .../table/calculator/RecordSingleTableInventoryCalculator.java |  4 ++--
 .../pipeline/core/ingest/dumper/inventory/InventoryDumper.java |  6 +++---
 ...ValueReader.java => DialectInventoryColumnValueReader.java} |  4 ++--
 ...ReaderEngine.java => InventoryColumnValueReaderEngine.java} | 10 +++++-----
 .../MySQLInventoryColumnValueReader.java}                      |  8 ++++----
 ....dumper.inventory.column.DialectInventoryColumnValueReader} |  2 +-
 .../OpenGaussInventoryColumnValueReader.java}                  |  8 ++++----
 ....dumper.inventory.column.DialectInventoryColumnValueReader} |  2 +-
 .../PostgreSQLInventoryColumnValueReader.java}                 |  8 ++++----
 ....dumper.inventory.column.DialectInventoryColumnValueReader} |  2 +-
 ...gineTest.java => InventoryColumnValueReaderEngineTest.java} |  6 +++---
 ...olumnValueReader.java => H2InventoryColumnValueReader.java} |  6 +++---
 ....dumper.inventory.column.DialectInventoryColumnValueReader} |  2 +-
 13 files changed, 34 insertions(+), 34 deletions(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/table/calculator/RecordSingleTableInventoryCalculator.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/table/calculator/RecordSingleTableInventoryCalculator.java
index cab1bb413f6..493d4295c6d 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/table/calculator/RecordSingleTableInventoryCalculator.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/table/calculator/RecordSingleTableInventoryCalculator.java
@@ -22,7 +22,7 @@ import 
org.apache.shardingsphere.data.pipeline.core.consistencycheck.result.Reco
 import 
org.apache.shardingsphere.data.pipeline.core.consistencycheck.result.SingleTableInventoryCalculatedResult;
 import 
org.apache.shardingsphere.data.pipeline.core.exception.PipelineJobCancelingException;
 import 
org.apache.shardingsphere.data.pipeline.core.exception.data.PipelineTableDataConsistencyCheckLoadingFailedException;
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.ColumnValueReaderEngine;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.InventoryColumnValueReaderEngine;
 import 
org.apache.shardingsphere.data.pipeline.core.query.JDBCStreamQueryBuilder;
 import 
org.apache.shardingsphere.data.pipeline.core.sqlbuilder.sql.PipelineDataConsistencyCalculateSQLBuilder;
 import org.apache.shardingsphere.infra.annotation.HighFrequencyInvocation;
@@ -59,7 +59,7 @@ public final class RecordSingleTableInventoryCalculator 
extends AbstractStreamin
         try {
             List<Map<String, Object>> records = new LinkedList<>();
             Object maxUniqueKeyValue = null;
-            ColumnValueReaderEngine columnValueReaderEngine = new 
ColumnValueReaderEngine(param.getDatabaseType());
+            InventoryColumnValueReaderEngine columnValueReaderEngine = new 
InventoryColumnValueReaderEngine(param.getDatabaseType());
             ResultSet resultSet = calculationContext.getResultSet();
             ResultSetMetaData resultSetMetaData = resultSet.getMetaData();
             while (resultSet.next()) {
diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
index bc684a1a1cd..cfb82e7dcfc 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
@@ -27,7 +27,7 @@ import 
org.apache.shardingsphere.data.pipeline.core.exception.param.PipelineInva
 import 
org.apache.shardingsphere.data.pipeline.core.execute.AbstractPipelineLifecycleRunnable;
 import org.apache.shardingsphere.data.pipeline.core.channel.PipelineChannel;
 import org.apache.shardingsphere.data.pipeline.core.ingest.dumper.Dumper;
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.ColumnValueReaderEngine;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.InventoryColumnValueReaderEngine;
 import 
org.apache.shardingsphere.data.pipeline.core.ingest.position.IngestPosition;
 import 
org.apache.shardingsphere.data.pipeline.core.ingest.position.type.finished.IngestFinishedPosition;
 import 
org.apache.shardingsphere.data.pipeline.core.ingest.position.type.pk.PrimaryKeyIngestPosition;
@@ -81,7 +81,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
     
     private final PipelineInventoryDumpSQLBuilder inventoryDumpSQLBuilder;
     
-    private final ColumnValueReaderEngine columnValueReaderEngine;
+    private final InventoryColumnValueReaderEngine columnValueReaderEngine;
     
     private final AtomicReference<Statement> runningStatement = new 
AtomicReference<>();
     
@@ -92,7 +92,7 @@ public final class InventoryDumper extends 
AbstractPipelineLifecycleRunnable imp
         this.metaDataLoader = metaDataLoader;
         DatabaseType databaseType = 
dumperContext.getCommonContext().getDataSourceConfig().getDatabaseType();
         inventoryDumpSQLBuilder = new 
PipelineInventoryDumpSQLBuilder(databaseType);
-        columnValueReaderEngine = new ColumnValueReaderEngine(databaseType);
+        columnValueReaderEngine = new 
InventoryColumnValueReaderEngine(databaseType);
     }
     
     @Override
diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectColumnValueReader.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectInventoryColumnValueReader.java
similarity index 92%
rename from 
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectColumnValueReader.java
rename to 
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectInventoryColumnValueReader.java
index c3b10fbb409..2a91608e976 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectColumnValueReader.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/DialectInventoryColumnValueReader.java
@@ -26,10 +26,10 @@ import java.sql.SQLException;
 import java.util.Optional;
 
 /**
- * Dialect column value reader.
+ * Dialect inventory column value reader.
  */
 @SingletonSPI
-public interface DialectColumnValueReader extends DatabaseTypedSPI {
+public interface DialectInventoryColumnValueReader extends DatabaseTypedSPI {
     
     /**
      * Read dialect column value.
diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/InventoryColumnValueReaderEngine.java
similarity index 94%
rename from 
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
rename to 
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/InventoryColumnValueReaderEngine.java
index 33efde4677f..e7e5efd1e2a 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/ColumnValueReaderEngine.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/column/InventoryColumnValueReaderEngine.java
@@ -30,14 +30,14 @@ import java.sql.Types;
 import java.util.Optional;
 
 /**
- * Column value reader engine.
+ * Inventory column value reader engine.
  */
-public final class ColumnValueReaderEngine {
+public final class InventoryColumnValueReaderEngine {
     
-    private final DialectColumnValueReader columnReader;
+    private final DialectInventoryColumnValueReader columnReader;
     
-    public ColumnValueReaderEngine(final DatabaseType databaseType) {
-        columnReader = 
DatabaseTypedSPILoader.findService(DialectColumnValueReader.class, 
databaseType).orElse(null);
+    public InventoryColumnValueReaderEngine(final DatabaseType databaseType) {
+        columnReader = 
DatabaseTypedSPILoader.findService(DialectInventoryColumnValueReader.class, 
databaseType).orElse(null);
     }
     
     /**
diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/binlog/column/MySQLColumnValueReader.java
 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/inventory/MySQLInventoryColumnValueReader.java
similarity index 85%
rename from 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/binlog/column/MySQLColumnValueReader.java
rename to 
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/inventory/MySQLInventoryColumnValueReader.java
index fbfab3957ab..2a13b984974 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/binlog/column/MySQLColumnValueReader.java
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/inventory/MySQLInventoryColumnValueReader.java
@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.data.pipeline.mysql.ingest.binlog.column;
+package org.apache.shardingsphere.data.pipeline.mysql.ingest.inventory;
 
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader;
 
 import java.sql.ResultSet;
 import java.sql.ResultSetMetaData;
@@ -25,9 +25,9 @@ import java.sql.SQLException;
 import java.util.Optional;
 
 /**
- * Column value reader for MySQL.
+ * Inventory column value reader for MySQL.
  */
-public final class MySQLColumnValueReader implements DialectColumnValueReader {
+public final class MySQLInventoryColumnValueReader implements 
DialectInventoryColumnValueReader {
     
     private static final String YEAR_DATA_TYPE = "YEAR";
     
diff --git 
a/kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
 
b/kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
similarity index 89%
rename from 
kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
rename to 
kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
index d2d577d634d..406fe0f0b81 100644
--- 
a/kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
+++ 
b/kernel/data-pipeline/dialect/mysql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-org.apache.shardingsphere.data.pipeline.mysql.ingest.binlog.column.MySQLColumnValueReader
+org.apache.shardingsphere.data.pipeline.mysql.ingest.inventory.MySQLInventoryColumnValueReader
diff --git 
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/column/OpenGaussColumnValueReader.java
 
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/inventory/OpenGaussInventoryColumnValueReader.java
similarity index 92%
rename from 
kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/column/OpenGaussColumnValueReader.java
rename to 
kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/inventory/OpenGaussInventoryColumnValueReader.java
index 052419d270e..aa69d62fa75 100644
--- 
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/column/OpenGaussColumnValueReader.java
+++ 
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/inventory/OpenGaussInventoryColumnValueReader.java
@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.data.pipeline.opengauss.ingest.wal.column;
+package org.apache.shardingsphere.data.pipeline.opengauss.ingest.inventory;
 
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader;
 
 import java.sql.ResultSet;
 import java.sql.ResultSetMetaData;
@@ -26,9 +26,9 @@ import java.sql.Types;
 import java.util.Optional;
 
 /**
- * Column value reader for openGauss.
+ * Inventory column value reader for openGauss.
  */
-public final class OpenGaussColumnValueReader implements 
DialectColumnValueReader {
+public final class OpenGaussInventoryColumnValueReader implements 
DialectInventoryColumnValueReader {
     
     private static final String MONEY_TYPE = "money";
     
diff --git 
a/kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
 
b/kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
similarity index 88%
rename from 
kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
rename to 
kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
index be25902afc5..f48a43c060f 100644
--- 
a/kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
+++ 
b/kernel/data-pipeline/dialect/opengauss/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-org.apache.shardingsphere.data.pipeline.opengauss.ingest.wal.column.OpenGaussColumnValueReader
+org.apache.shardingsphere.data.pipeline.opengauss.ingest.inventory.OpenGaussInventoryColumnValueReader
diff --git 
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/column/PostgreSQLColumnValueReader.java
 
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/inventory/PostgreSQLInventoryColumnValueReader.java
similarity index 92%
rename from 
kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/column/PostgreSQLColumnValueReader.java
rename to 
kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/inventory/PostgreSQLInventoryColumnValueReader.java
index 7f0ae7eaf6d..1f42bd4bef3 100644
--- 
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/column/PostgreSQLColumnValueReader.java
+++ 
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/inventory/PostgreSQLInventoryColumnValueReader.java
@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.data.pipeline.postgresql.ingest.wal.column;
+package org.apache.shardingsphere.data.pipeline.postgresql.ingest.inventory;
 
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader;
 import org.postgresql.util.PGobject;
 
 import java.sql.ResultSet;
@@ -27,9 +27,9 @@ import java.sql.Types;
 import java.util.Optional;
 
 /**
- * Column value reader for PostgreSQL.
+ * Inventory column value reader for PostgreSQL.
  */
-public final class PostgreSQLColumnValueReader implements 
DialectColumnValueReader {
+public final class PostgreSQLInventoryColumnValueReader implements 
DialectInventoryColumnValueReader {
     
     private static final String PG_MONEY_TYPE = "money";
     
diff --git 
a/kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
 
b/kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
similarity index 88%
rename from 
kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
rename to 
kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
index f767b289853..7ebdd17c22f 100644
--- 
a/kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
+++ 
b/kernel/data-pipeline/dialect/postgresql/src/main/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-org.apache.shardingsphere.data.pipeline.postgresql.ingest.wal.column.PostgreSQLColumnValueReader
+org.apache.shardingsphere.data.pipeline.postgresql.ingest.inventory.PostgreSQLInventoryColumnValueReader
diff --git 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/ColumnValueReaderEngineTest.java
 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/InventoryColumnValueReaderEngineTest.java
similarity index 92%
rename from 
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/ColumnValueReaderEngineTest.java
rename to 
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/InventoryColumnValueReaderEngineTest.java
index 64c4797f29b..abe7b8b64a6 100644
--- 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/ColumnValueReaderEngineTest.java
+++ 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/dump/InventoryColumnValueReaderEngineTest.java
@@ -19,7 +19,7 @@ package 
org.apache.shardingsphere.test.it.data.pipeline.core.dump;
 
 import com.zaxxer.hikari.HikariDataSource;
 import org.apache.commons.lang3.RandomStringUtils;
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.ColumnValueReaderEngine;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.InventoryColumnValueReaderEngine;
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
 import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
 import org.junit.jupiter.api.Test;
@@ -32,11 +32,11 @@ import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.is;
 import static org.junit.jupiter.api.Assertions.assertNull;
 
-class ColumnValueReaderEngineTest {
+class InventoryColumnValueReaderEngineTest {
     
     @Test
     void assertReadValue() throws SQLException {
-        ColumnValueReaderEngine columnValueReaderEngine = new 
ColumnValueReaderEngine(TypedSPILoader.getService(DatabaseType.class, "H2"));
+        InventoryColumnValueReaderEngine columnValueReaderEngine = new 
InventoryColumnValueReaderEngine(TypedSPILoader.getService(DatabaseType.class, 
"H2"));
         try (
                 HikariDataSource dataSource = 
createDataSource(RandomStringUtils.randomAlphanumeric(6));
                 Connection connection = dataSource.getConnection()) {
diff --git 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2ColumnValueReader.java
 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2InventoryColumnValueReader.java
similarity index 87%
rename from 
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2ColumnValueReader.java
rename to 
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2InventoryColumnValueReader.java
index 149d5c6fe2b..20e968f2fe9 100644
--- 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2ColumnValueReader.java
+++ 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2InventoryColumnValueReader.java
@@ -17,16 +17,16 @@
 
 package org.apache.shardingsphere.test.it.data.pipeline.core.fixture.h2.dumper;
 
-import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader;
+import 
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader;
 
 import java.sql.ResultSet;
 import java.sql.ResultSetMetaData;
 import java.util.Optional;
 
 /**
- * Column value reader for H2.
+ * Inventory column value reader for H2.
  */
-public final class H2ColumnValueReader implements DialectColumnValueReader {
+public final class H2InventoryColumnValueReader implements 
DialectInventoryColumnValueReader {
     
     @Override
     public Optional<Object> read(final ResultSet resultSet, final 
ResultSetMetaData metaData, final int columnIndex) {
diff --git 
a/test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
 
b/test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
similarity index 95%
rename from 
test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
rename to 
test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
index 0349750b070..5459813bdb6 100644
--- 
a/test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectColumnValueReader
+++ 
b/test/it/pipeline/src/test/resources/META-INF/services/org.apache.shardingsphere.data.pipeline.core.ingest.dumper.inventory.column.DialectInventoryColumnValueReader
@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-org.apache.shardingsphere.test.it.data.pipeline.core.fixture.h2.dumper.H2ColumnValueReader
+org.apache.shardingsphere.test.it.data.pipeline.core.fixture.h2.dumper.H2InventoryColumnValueReader

Reply via email to