This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 78fb4a7b898 Move DatabaseTypeUtils (#32632)
78fb4a7b898 is described below

commit 78fb4a7b898c4787ccbd4e6a63b8aef7cf63e14d
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Aug 22 17:38:31 2024 +0800

    Move DatabaseTypeUtils (#32632)
    
    * Move DatabaseTypeUtils
    
    * Move DatabaseTypeUtils
    
    * Move DatabaseTypeUtils
---
 .../infra}/util/DatabaseTypeUtils.java             |  2 +-
 .../infra/util/DatabaseTypeUtilsTest.java          | 38 ++++++++++++++++++++++
 .../ingest/dumper/inventory/InventoryDumper.java   |  2 +-
 3 files changed, 40 insertions(+), 2 deletions(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/DatabaseTypeUtils.java
 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtils.java
similarity index 96%
rename from 
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/DatabaseTypeUtils.java
rename to 
infra/common/src/main/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtils.java
index f5be779e7de..30b750decd8 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/DatabaseTypeUtils.java
+++ 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtils.java
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.shardingsphere.data.pipeline.core.util;
+package org.apache.shardingsphere.infra.util;
 
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
diff --git 
a/infra/common/src/test/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtilsTest.java
 
b/infra/common/src/test/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtilsTest.java
new file mode 100644
index 00000000000..e7b10862886
--- /dev/null
+++ 
b/infra/common/src/test/java/org/apache/shardingsphere/infra/util/DatabaseTypeUtilsTest.java
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.util;
+
+import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
+import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class DatabaseTypeUtilsTest {
+    
+    @Test
+    void assertIsMySQL() {
+        DatabaseType actual = TypedSPILoader.getService(DatabaseType.class, 
"MySQL");
+        assertTrue(DatabaseTypeUtils.isMySQL(actual));
+        actual = TypedSPILoader.getService(DatabaseType.class, "MariaDB");
+        assertTrue(DatabaseTypeUtils.isMySQL(actual));
+        actual = TypedSPILoader.getService(DatabaseType.class, "PostgreSQL");
+        assertFalse(DatabaseTypeUtils.isMySQL(actual));
+    }
+}
diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
index a5bca34cbac..09ba34b80ae 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/InventoryDumper.java
@@ -44,7 +44,7 @@ import 
org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineTable
 import 
org.apache.shardingsphere.data.pipeline.core.query.JDBCStreamQueryBuilder;
 import 
org.apache.shardingsphere.data.pipeline.core.ratelimit.JobRateLimitAlgorithm;
 import 
org.apache.shardingsphere.data.pipeline.core.sqlbuilder.sql.PipelineInventoryDumpSQLBuilder;
-import org.apache.shardingsphere.data.pipeline.core.util.DatabaseTypeUtils;
+import org.apache.shardingsphere.infra.util.DatabaseTypeUtils;
 import org.apache.shardingsphere.data.pipeline.core.util.PipelineJdbcUtils;
 import org.apache.shardingsphere.infra.annotation.HighFrequencyInvocation;
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;

Reply via email to