(shardingsphere) branch master updated: Add todo on InventoryRecordsCountCalculator (#32780)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new b675c2b2e0a Add todo on InventoryRecordsCountCalculator (#32780)
b675c2b2e0a is described below

commit b675c2b2e0a50f9d4afe73e83d591000dc070ef2
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Tue Sep 3 09:54:50 2024 +0800

    Add todo on InventoryRecordsCountCalculator (#32780)
    
    * Add todo on InventoryRecordsCountCalculator
    
    * Add todo on InventoryRecordsCountCalculator
---
 .../preparer/inventory/calculator/InventoryRecordsCountCalculator.java  | 1 +
 .../shardingsphere/data/pipeline/cdc/core/prepare/CDCJobPreparer.java   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/preparer/inventory/calculator/InventoryRecordsCountCalculator.java
 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/preparer/inventory/calculator/InventoryRecordsCountCalculator.java
index 4d99e401c58..de2842aa45a 100644
--- 
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/preparer/inventory/calculator/InventoryRecordsCountCalculator.java
+++ 
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/preparer/inventory/calculator/InventoryRecordsCountCalculator.java
@@ -58,6 +58,7 @@ public final class InventoryRecordsCountCalculator {
         PipelinePrepareSQLBuilder pipelineSQLBuilder = new 
PipelinePrepareSQLBuilder(dataSource.getDatabaseType());
         Optional<String> sql = 
pipelineSQLBuilder.buildEstimatedCountSQL(schemaName, actualTableName);
         try {
+            // TODO Get estimate count from meta table, native DataSource is 
ok, but ShardingSphereDataSource has problem
             if (sql.isPresent() && 
dumperContext.getCommonContext().getDataSourceConfig() instanceof 
StandardPipelineDataSourceConfiguration) {
                 DatabaseType databaseType = 
TypedSPILoader.getService(DatabaseType.class, 
dataSource.getDatabaseType().getType());
                 long result = getEstimatedCount(databaseType, dataSource, 
sql.get());
diff --git 
a/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/prepare/CDCJobPreparer.java
 
b/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/prepare/CDCJobPreparer.java
index 657225f087f..c05de933591 100644
--- 
a/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/prepare/CDCJobPreparer.java
+++ 
b/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/prepare/CDCJobPreparer.java
@@ -77,7 +77,7 @@ public final class CDCJobPreparer {
      * @param jobItemContexts job item contexts
      */
     public void initTasks(final Collection<CDCJobItemContext> jobItemContexts) 
{
-        // TODO Use pipeline tree to build it
+        // TODO Use DAG to build it
         AtomicBoolean inventoryImporterUsed = new AtomicBoolean();
         List<CDCChannelProgressPair> inventoryChannelProgressPairs = new 
CopyOnWriteArrayList<>();
         AtomicBoolean incrementalImporterUsed = new AtomicBoolean();