(shardingsphere) branch master updated: Refactor DataChangedEventListenerRegistry (#32868)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new aac5da3af99 Refactor DataChangedEventListenerRegistry (#32868)
aac5da3af99 is described below

commit aac5da3af99b999c0de8d886c21e9ba8d31d7ccc
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sat Sep 14 19:19:14 2024 +0800

    Refactor DataChangedEventListenerRegistry (#32868)
    
    * Refactor DataChangedEventListenerRegistry
    
    * Refactor DataChangedEventListenerRegistry
---
 .../listener/DataChangedEventListenerRegistry.java | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/listener/DataChangedEventListenerRegistry.java
 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/listener/DataChangedEventListenerRegistry.java
index 4c7b7fe598a..a6f5eea8fe6 100644
--- 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/listener/DataChangedEventListenerRegistry.java
+++ 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/listener/DataChangedEventListenerRegistry.java
@@ -47,16 +47,16 @@ public final class DataChangedEventListenerRegistry {
      * Register data changed event listeners.
      */
     public void register() {
-        registerDatabaseRequiredListeners();
-        for (DispatchEventBuilder<?> each : 
ShardingSphereServiceLoader.getServiceInstances(DispatchEventBuilder.class)) {
-            register(each);
-        }
+        databaseNames.forEach(this::register);
+        
ShardingSphereServiceLoader.getServiceInstances(DispatchEventBuilder.class).forEach(this::register);
+    }
+    
+    private void register(final String databaseName) {
+        
listenerManager.addListener(DatabaseMetaDataNode.getDatabaseNamePath(databaseName),
 new MetaDataChangedListener(eventBusContext));
     }
     
     private void register(final DispatchEventBuilder<?> builder) {
-        for (String each : builder.getSubscribedKeys()) {
-            register(each, builder);
-        }
+        builder.getSubscribedKeys().forEach(each -> register(each, builder));
     }
     
     private void register(final String subscribedKey, final 
DispatchEventBuilder<?> builder) {
@@ -66,12 +66,4 @@ public final class DataChangedEventListenerRegistry {
             }
         });
     }
-    
-    private void registerDatabaseRequiredListeners() {
-        registerMetaDataChangedEventListener();
-    }
-    
-    private void registerMetaDataChangedEventListener() {
-        databaseNames.forEach(each -> 
listenerManager.addListener(DatabaseMetaDataNode.getDatabaseNamePath(each), new 
MetaDataChangedListener(eventBusContext)));
-    }
 }