This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 70409c31290 Add test cases on RuleItemChangedSubscriber (#32890)
70409c31290 is described below
commit 70409c3129065608c05cc49d1bbe5c5b7b80b573
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Sep 15 21:16:40 2024 +0800
Add test cases on RuleItemChangedSubscriber (#32890)
---
.../dispatch/ComputeNodeStateSubscriber.java | 1 +
.../GlobalRuleConfigurationEventSubscriber.java | 2 +-
.../dispatch/ListenerAssistedSubscriber.java | 2 +-
.../dispatch/ProcessListChangedSubscriber.java | 2 +-
.../dispatch/PropertiesEventSubscriber.java | 1 +
.../dispatch/QualifiedDataSourceSubscriber.java | 1 +
.../dispatch/RuleItemChangedSubscriber.java | 1 +
.../dispatch/StorageUnitEventSubscriber.java | 1 +
.../dispatch/RuleItemChangedSubscriberTest.java | 61 ++++++++++++++++++++++
9 files changed, 69 insertions(+), 3 deletions(-)
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ComputeNodeStateSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ComputeNodeStateSubscriber.java
index 82fd4f4d1ee..e00ed827f90 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ComputeNodeStateSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ComputeNodeStateSubscriber.java
@@ -32,6 +32,7 @@ import
org.apache.shardingsphere.mode.event.dispatch.state.compute.instance.Inst
* Compute node state subscriber.
*/
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class ComputeNodeStateSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/GlobalRuleConfigurationEventSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/GlobalRuleConfigurationEventSubscriber.java
index 098a1cbb88b..6093b87bd5f 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/GlobalRuleConfigurationEventSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/GlobalRuleConfigurationEventSubscriber.java
@@ -32,8 +32,8 @@ import java.util.Optional;
/**
* Global rule configuration event subscriber.
*/
-@SuppressWarnings("unused")
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class GlobalRuleConfigurationEventSubscriber implements
EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ListenerAssistedSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ListenerAssistedSubscriber.java
index ff38e24f6ed..8561b6d7a25 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ListenerAssistedSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ListenerAssistedSubscriber.java
@@ -34,8 +34,8 @@ import
org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepositor
/**
* Listener assisted subscriber.
*/
-@SuppressWarnings("unused")
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class ListenerAssistedSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ProcessListChangedSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ProcessListChangedSubscriber.java
index c3ef631a0d9..2d7ddc30702 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ProcessListChangedSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/ProcessListChangedSubscriber.java
@@ -40,8 +40,8 @@ import java.util.Collection;
/**
* Process list changed subscriber.
*/
-@SuppressWarnings("unused")
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class ProcessListChangedSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/PropertiesEventSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/PropertiesEventSubscriber.java
index 40b91c20131..dcbbacebdff 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/PropertiesEventSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/PropertiesEventSubscriber.java
@@ -28,6 +28,7 @@ import org.apache.shardingsphere.mode.manager.ContextManager;
* Properties event subscriber.
*/
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class PropertiesEventSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/QualifiedDataSourceSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/QualifiedDataSourceSubscriber.java
index 8905f3407c5..e188ef13277 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/QualifiedDataSourceSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/QualifiedDataSourceSubscriber.java
@@ -31,6 +31,7 @@ import
org.apache.shardingsphere.mode.event.dispatch.state.storage.QualifiedData
* Qualified data source subscriber.
*/
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public class QualifiedDataSourceSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriber.java
index 56ab9717453..f2594d2e3d3 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriber.java
@@ -30,6 +30,7 @@ import java.sql.SQLException;
* Rule item changed subscriber.
*/
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class RuleItemChangedSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
index 8b140fd2114..f9c4d5ea30a 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
@@ -30,6 +30,7 @@ import org.apache.shardingsphere.mode.manager.ContextManager;
* Storage unit event subscriber.
*/
@RequiredArgsConstructor
+@SuppressWarnings("unused")
public final class StorageUnitEventSubscriber implements EventSubscriber {
private final ContextManager contextManager;
diff --git
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriberTest.java
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriberTest.java
new file mode 100644
index 00000000000..e776e5cf120
--- /dev/null
+++
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/RuleItemChangedSubscriberTest.java
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.mode.manager.cluster.event.subscriber.dispatch;
+
+import
org.apache.shardingsphere.mode.event.dispatch.rule.alter.AlterRuleItemEvent;
+import
org.apache.shardingsphere.mode.event.dispatch.rule.drop.DropRuleItemEvent;
+import org.apache.shardingsphere.mode.manager.ContextManager;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Answers;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.sql.SQLException;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+
+@ExtendWith(MockitoExtension.class)
+class RuleItemChangedSubscriberTest {
+
+ private RuleItemChangedSubscriber subscriber;
+
+ @Mock(answer = Answers.RETURNS_DEEP_STUBS)
+ private ContextManager contextManager;
+
+ @BeforeEach
+ void setUp() {
+ subscriber = new RuleItemChangedSubscriber(contextManager);
+ }
+
+ @Test
+ void assertRenewWithAlterRuleItemEvent() throws SQLException {
+ AlterRuleItemEvent event = mock(AlterRuleItemEvent.class);
+ subscriber.renew(event);
+
verify(contextManager.getMetaDataContextManager().getRuleItemManager()).alterRuleItem(event);
+ }
+
+ @Test
+ void assertRenewWithDropRuleItemEvent() throws SQLException {
+ DropRuleItemEvent event = mock(DropRuleItemEvent.class);
+ subscriber.renew(event);
+
verify(contextManager.getMetaDataContextManager().getRuleItemManager()).dropRuleItem(event);
+ }
+}
