This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new a9fde6bba46 Add test cases on StorageUnitEventSubscriber (#32892)
a9fde6bba46 is described below
commit a9fde6bba46804846e15712806c85ae5f79080d8
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Sep 15 21:32:59 2024 +0800
Add test cases on StorageUnitEventSubscriber (#32892)
* Add test cases on StateChangedSubscriber
* Add test cases on StorageUnitEventSubscriber
---
.../dispatch/StorageUnitEventSubscriber.java | 17 +++---
.../dispatch/StorageUnitEventSubscriberTest.java | 71 ++++++++++++++++++++++
2 files changed, 80 insertions(+), 8 deletions(-)
diff --git
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
index f9c4d5ea30a..c5b79be4f4a 100644
---
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
+++
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriber.java
@@ -42,10 +42,11 @@ public final class StorageUnitEventSubscriber implements
EventSubscriber {
*/
@Subscribe
public synchronized void renew(final RegisterStorageUnitEvent event) {
-
Preconditions.checkArgument(event.getActiveVersion().equals(contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService()
- .getActiveVersionByFullPath(event.getActiveVersionKey())),
"Invalid active version: %s of key: %s", event.getActiveVersion(),
event.getActiveVersionKey());
-
contextManager.getMetaDataContextManager().getStorageUnitManager().registerStorageUnit(event.getDatabaseName(),
-
contextManager.getPersistServiceFacade().getMetaDataPersistService().getDataSourceUnitService().load(event.getDatabaseName(),
event.getStorageUnitName()));
+ Preconditions.checkArgument(event.getActiveVersion().equals(
+
contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService().getActiveVersionByFullPath(event.getActiveVersionKey())),
+ "Invalid active version: %s of key: %s",
event.getActiveVersion(), event.getActiveVersionKey());
+
contextManager.getMetaDataContextManager().getStorageUnitManager().registerStorageUnit(
+ event.getDatabaseName(),
contextManager.getPersistServiceFacade().getMetaDataPersistService().getDataSourceUnitService().load(event.getDatabaseName(),
event.getStorageUnitName()));
}
/**
@@ -55,8 +56,9 @@ public final class StorageUnitEventSubscriber implements
EventSubscriber {
*/
@Subscribe
public synchronized void renew(final AlterStorageUnitEvent event) {
-
Preconditions.checkArgument(event.getActiveVersion().equals(contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService()
- .getActiveVersionByFullPath(event.getActiveVersionKey())),
"Invalid active version: %s of key: %s", event.getActiveVersion(),
event.getActiveVersionKey());
+ Preconditions.checkArgument(event.getActiveVersion().equals(
+
contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService().getActiveVersionByFullPath(event.getActiveVersionKey())),
+ "Invalid active version: %s of key: %s",
event.getActiveVersion(), event.getActiveVersionKey());
contextManager.getMetaDataContextManager().getStorageUnitManager().alterStorageUnit(
event.getDatabaseName(),
contextManager.getPersistServiceFacade().getMetaDataPersistService().getDataSourceUnitService().load(event.getDatabaseName(),
event.getStorageUnitName()));
}
@@ -68,8 +70,7 @@ public final class StorageUnitEventSubscriber implements
EventSubscriber {
*/
@Subscribe
public synchronized void renew(final UnregisterStorageUnitEvent event) {
-
Preconditions.checkState(contextManager.getMetaDataContexts().getMetaData().containsDatabase(event.getDatabaseName()),
- "No database '%s' exists.", event.getDatabaseName());
+
Preconditions.checkState(contextManager.getMetaDataContexts().getMetaData().containsDatabase(event.getDatabaseName()),
"No database '%s' exists.", event.getDatabaseName());
contextManager.getMetaDataContextManager().getStorageUnitManager().unregisterStorageUnit(event.getDatabaseName(),
event.getStorageUnitName());
}
}
diff --git
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriberTest.java
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriberTest.java
new file mode 100644
index 00000000000..3f354644846
--- /dev/null
+++
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/subscriber/dispatch/StorageUnitEventSubscriberTest.java
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.mode.manager.cluster.event.subscriber.dispatch;
+
+import
org.apache.shardingsphere.mode.event.dispatch.datasource.unit.AlterStorageUnitEvent;
+import
org.apache.shardingsphere.mode.event.dispatch.datasource.unit.RegisterStorageUnitEvent;
+import
org.apache.shardingsphere.mode.event.dispatch.datasource.unit.UnregisterStorageUnitEvent;
+import org.apache.shardingsphere.mode.manager.ContextManager;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Answers;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.Collections;
+
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+class StorageUnitEventSubscriberTest {
+
+ private StorageUnitEventSubscriber subscriber;
+
+ @Mock(answer = Answers.RETURNS_DEEP_STUBS)
+ private ContextManager contextManager;
+
+ @BeforeEach
+ void setUp() {
+ subscriber = new StorageUnitEventSubscriber(contextManager);
+ }
+
+ @Test
+ void assertRenewWithRegisterStorageUnitEvent() {
+
when(contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService().getActiveVersionByFullPath("key")).thenReturn("value");
+
when(contextManager.getPersistServiceFacade().getMetaDataPersistService().getDataSourceUnitService().load("foo_db",
"foo_unit")).thenReturn(Collections.emptyMap());
+ subscriber.renew(new RegisterStorageUnitEvent("foo_db", "foo_unit",
"key", "value"));
+
verify(contextManager.getMetaDataContextManager().getStorageUnitManager()).registerStorageUnit("foo_db",
Collections.emptyMap());
+ }
+
+ @Test
+ void assertRenewWithAlterStorageUnitEvent() {
+
when(contextManager.getPersistServiceFacade().getMetaDataPersistService().getMetaDataVersionPersistService().getActiveVersionByFullPath("key")).thenReturn("value");
+
when(contextManager.getPersistServiceFacade().getMetaDataPersistService().getDataSourceUnitService().load("foo_db",
"foo_unit")).thenReturn(Collections.emptyMap());
+ subscriber.renew(new AlterStorageUnitEvent("foo_db", "foo_unit",
"key", "value"));
+
verify(contextManager.getMetaDataContextManager().getStorageUnitManager()).alterStorageUnit("foo_db",
Collections.emptyMap());
+ }
+
+ @Test
+ void assertRenewWithUnregisterStorageUnitEvent() {
+
when(contextManager.getMetaDataContexts().getMetaData().containsDatabase("foo_db")).thenReturn(true);
+ subscriber.renew(new UnregisterStorageUnitEvent("foo_db", "foo_unit"));
+
verify(contextManager.getMetaDataContextManager().getStorageUnitManager()).unregisterStorageUnit("foo_db",
"foo_unit");
+ }
+}
