(shardingsphere) branch master updated: Add more test cases on QualifiedDataSourceDispatchEventBuilder (#32903)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new bcd09e80da0 Add more test cases on 
QualifiedDataSourceDispatchEventBuilder (#32903)
bcd09e80da0 is described below

commit bcd09e80da001fd1d491e58f244a7e881ec8b794
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Sep 16 14:49:42 2024 +0800

    Add more test cases on QualifiedDataSourceDispatchEventBuilder (#32903)
---
 ...ualifiedDataSourceDispatchEventBuilderTest.java | 33 +++++++++++-----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/builder/QualifiedDataSourceDispatchEventBuilderTest.java
 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/builder/QualifiedDataSourceDispatchEventBuilderTest.java
index 8245f3efe71..e227f233fec 100644
--- 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/builder/QualifiedDataSourceDispatchEventBuilderTest.java
+++ 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/event/builder/QualifiedDataSourceDispatchEventBuilderTest.java
@@ -36,30 +36,29 @@ class QualifiedDataSourceDispatchEventBuilderTest {
     private final QualifiedDataSourceDispatchEventBuilder builder = new 
QualifiedDataSourceDispatchEventBuilder();
     
     @Test
-    void assertCreateEnabledQualifiedDataSourceChangedEvent() {
-        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources/replica_query_db.readwrite_ds.replica_ds_0",
 "state: ENABLED\n", Type.ADDED));
-        assertTrue(actual.isPresent());
-        QualifiedDataSourceStateEvent actualEvent = 
(QualifiedDataSourceStateEvent) actual.get();
-        assertThat(actualEvent.getQualifiedDataSource().getDatabaseName(), 
is("replica_query_db"));
-        assertThat(actualEvent.getQualifiedDataSource().getGroupName(), 
is("readwrite_ds"));
-        assertThat(actualEvent.getQualifiedDataSource().getDataSourceName(), 
is("replica_ds_0"));
-        assertThat(actualEvent.getStatus().getState(), 
is(DataSourceState.ENABLED));
+    void assertGetSubscribedKey() {
+        assertThat(builder.getSubscribedKey(), 
is("/nodes/qualified_data_sources"));
     }
     
     @Test
-    void assertCreateDisabledQualifiedDataSourceChangedEvent() {
-        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources/replica_query_db.readwrite_ds.replica_ds_0",
 "state: DISABLED\n", Type.DELETED));
+    void assertBuildQualifiedDataSourceStateEvent() {
+        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources/foo_db.foo_group.foo_ds", 
"state: ENABLED", Type.ADDED));
         assertTrue(actual.isPresent());
-        QualifiedDataSourceStateEvent actualEvent = 
(QualifiedDataSourceStateEvent) actual.get();
-        assertThat(actualEvent.getQualifiedDataSource().getDatabaseName(), 
is("replica_query_db"));
-        assertThat(actualEvent.getQualifiedDataSource().getGroupName(), 
is("readwrite_ds"));
-        assertThat(actualEvent.getQualifiedDataSource().getDataSourceName(), 
is("replica_ds_0"));
-        assertThat(actualEvent.getStatus().getState(), 
is(DataSourceState.DISABLED));
+        assertThat(((QualifiedDataSourceStateEvent) 
actual.get()).getQualifiedDataSource().getDatabaseName(), is("foo_db"));
+        assertThat(((QualifiedDataSourceStateEvent) 
actual.get()).getQualifiedDataSource().getGroupName(), is("foo_group"));
+        assertThat(((QualifiedDataSourceStateEvent) 
actual.get()).getQualifiedDataSource().getDataSourceName(), is("foo_ds"));
+        assertThat(((QualifiedDataSourceStateEvent) 
actual.get()).getStatus().getState(), is(DataSourceState.ENABLED));
+    }
+    
+    @Test
+    void assertBuildWithEmptyValue() {
+        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources/foo_db.foo_group.foo_ds", "", 
Type.ADDED));
+        assertFalse(actual.isPresent());
     }
     
     @Test
-    void assertCreateEmptyEvent() {
-        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources/replica_query_db.readwrite_ds.replica_ds_0",
 "", Type.ADDED));
+    void assertBuildWithoutQualifiedDataSource() {
+        Optional<DispatchEvent> actual = builder.build(new 
DataChangedEvent("/nodes/qualified_data_sources", "state: DISABLED", 
Type.ADDED));
         assertFalse(actual.isPresent());
     }
 }