This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new fab871b9c0c Add test cases on StatisticsCollectJobWorker (#32925)
fab871b9c0c is described below
commit fab871b9c0c545ab1b64eeb7204174e19a7b54cb
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Sep 19 12:34:09 2024 +0800
Add test cases on StatisticsCollectJobWorker (#32925)
---
.../collect/StatisticsCollectJobWorker.java | 15 ++---
.../collect/StatisticsCollectJobWorkerTest.java | 71 ++++++++++++++++++++++
2 files changed, 79 insertions(+), 7 deletions(-)
diff --git
a/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java
b/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java
index 0fce7189905..b84a776ebde 100644
---
a/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java
+++
b/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java
@@ -54,15 +54,16 @@ public final class StatisticsCollectJobWorker {
* Initialize job worker.
*/
public void initialize() {
- if (WORKER_INITIALIZED.compareAndSet(false, true)) {
- ModeConfiguration modeConfig =
contextManager.getComputeNodeInstanceContext().getModeConfiguration();
- if ("ZooKeeper".equals(modeConfig.getRepository().getType())) {
- scheduleJobBootstrap = new
ScheduleJobBootstrap(createRegistryCenter(modeConfig), new
StatisticsCollectJob(contextManager), createJobConfiguration());
- scheduleJobBootstrap.schedule();
- return;
- }
+ if (!WORKER_INITIALIZED.compareAndSet(false, true)) {
+ return;
+ }
+ ModeConfiguration modeConfig =
contextManager.getComputeNodeInstanceContext().getModeConfiguration();
+ if (!"ZooKeeper".equals(modeConfig.getRepository().getType())) {
log.warn("Can not collect statistics because of unsupported
cluster type: {}", modeConfig.getRepository().getType());
+ return;
}
+ scheduleJobBootstrap = new
ScheduleJobBootstrap(createRegistryCenter(modeConfig), new
StatisticsCollectJob(contextManager), createJobConfiguration());
+ scheduleJobBootstrap.schedule();
}
private CoordinatorRegistryCenter createRegistryCenter(final
ModeConfiguration modeConfig) {
diff --git
a/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java
b/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java
new file mode 100644
index 00000000000..dbe3978c4f4
--- /dev/null
+++
b/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.schedule.core.job.statistics.collect;
+
+import lombok.SneakyThrows;
+import
org.apache.shardingsphere.elasticjob.lite.api.bootstrap.impl.ScheduleJobBootstrap;
+import org.apache.shardingsphere.mode.manager.ContextManager;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Answers;
+import org.mockito.Mock;
+import org.mockito.internal.configuration.plugins.Plugins;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.mockito.Mockito.verify;
+
+@ExtendWith(MockitoExtension.class)
+class StatisticsCollectJobWorkerTest {
+
+ private StatisticsCollectJobWorker jobWorker;
+
+ @Mock(answer = Answers.RETURNS_DEEP_STUBS)
+ private ContextManager contextManager;
+
+ @BeforeEach
+ void setUp() {
+ jobWorker = new StatisticsCollectJobWorker(contextManager);
+ }
+
+ @Test
+ void assertInitializeTwice() {
+ jobWorker.initialize();
+ jobWorker.initialize();
+
verify(contextManager.getComputeNodeInstanceContext()).getModeConfiguration();
+ }
+
+ @Test
+ void assertInitializeWithNotZooKeeperRepository() {
+ jobWorker.initialize();
+ assertNull(getScheduleJobBootstrap());
+ }
+
+ @Test
+ void assertDestroy() {
+ jobWorker.destroy();
+ jobWorker.destroy();
+ assertNull(getScheduleJobBootstrap());
+ }
+
+ @SneakyThrows(ReflectiveOperationException.class)
+ private ScheduleJobBootstrap getScheduleJobBootstrap() {
+ return (ScheduleJobBootstrap)
Plugins.getMemberAccessor().get(StatisticsCollectJobWorker.class.getDeclaredField("scheduleJobBootstrap"),
StatisticsCollectJobWorker.class);
+ }
+}
