(shardingsphere) branch master updated: Add more test cases on ViewMetaDataNode (#32974)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 184c4f90dd3 Add more test cases on ViewMetaDataNode (#32974)
184c4f90dd3 is described below

commit 184c4f90dd3b4aa7e7cd5849def418a9d7c03895
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Tue Sep 24 13:30:23 2024 +0800

    Add more test cases on ViewMetaDataNode (#32974)
---
 .../node/metadata/ViewMetaDataNodeTest.java        | 51 +++++++++++++---------
 1 file changed, 30 insertions(+), 21 deletions(-)

diff --git 
a/kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/node/metadata/ViewMetaDataNodeTest.java
 
b/kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/node/metadata/ViewMetaDataNodeTest.java
index 87b6a97f40f..ad141c16bd6 100644
--- 
a/kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/node/metadata/ViewMetaDataNodeTest.java
+++ 
b/kernel/metadata/core/src/test/java/org/apache/shardingsphere/metadata/persist/node/metadata/ViewMetaDataNodeTest.java
@@ -17,38 +17,20 @@
 
 package org.apache.shardingsphere.metadata.persist.node.metadata;
 
-import org.apache.shardingsphere.metadata.persist.node.DatabaseMetaDataNode;
 import org.junit.jupiter.api.Test;
 
 import java.util.Optional;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class ViewMetaDataNodeTest {
     
     @Test
-    void assertGetViewName() {
-        Optional<String> actual = 
ViewMetaDataNode.getViewName("/metadata/foo_db/schemas/foo_schema/views/foo_view");
-        assertTrue(actual.isPresent());
-        assertThat(actual.get(), is("foo_view"));
-    }
-    
-    @Test
-    void assertIsViewActiveVersionNode() {
-        
assertTrue(ViewMetaDataNode.isViewActiveVersionNode("/metadata/foo_db/schemas/foo_schema/views/foo_view/active_version"));
-    }
-    
-    @Test
-    void assertIsViewNode() {
-        
assertTrue(ViewMetaDataNode.isViewNode("/metadata/foo_db/schemas/foo_schema/views/foo_view"));
-    }
-    
-    @Test
-    void assertGetVersionNodeByActiveVersionPath() {
-        
assertThat(DatabaseMetaDataNode.getVersionNodeByActiveVersionPath("/metadata/foo_db/schemas/foo_schema/views/foo_view/active_version",
 "0"),
-                
is("/metadata/foo_db/schemas/foo_schema/views/foo_view/versions/0"));
+    void assertGetMetaDataViewsNode() {
+        assertThat(ViewMetaDataNode.getMetaDataViewsNode("foo_db", 
"foo_schema"), is("/metadata/foo_db/schemas/foo_schema/views"));
     }
     
     @Test
@@ -77,4 +59,31 @@ class ViewMetaDataNodeTest {
         assertTrue(actual.isPresent());
         assertThat(actual.get(), is("foo_view"));
     }
+    
+    @Test
+    void assertGetTableNameByActiveVersionNodeIfNotFound() {
+        
assertFalse(ViewMetaDataNode.getViewNameByActiveVersionNode("/xxx/foo_db/schemas/foo_schema/views/foo_view/active_version").isPresent());
+    }
+    
+    @Test
+    void assertGetViewName() {
+        Optional<String> actual = 
ViewMetaDataNode.getViewName("/metadata/foo_db/schemas/foo_schema/views/foo_view");
+        assertTrue(actual.isPresent());
+        assertThat(actual.get(), is("foo_view"));
+    }
+    
+    @Test
+    void assertGetViewNameIfNotFound() {
+        
assertFalse(ViewMetaDataNode.getViewName("/xxx/foo_db/schemas/foo_schema/views/foo_view").isPresent());
+    }
+    
+    @Test
+    void assertIsViewActiveVersionNode() {
+        
assertTrue(ViewMetaDataNode.isViewActiveVersionNode("/metadata/foo_db/schemas/foo_schema/views/foo_view/active_version"));
+    }
+    
+    @Test
+    void assertIsViewNode() {
+        
assertTrue(ViewMetaDataNode.isViewNode("/metadata/foo_db/schemas/foo_schema/views/foo_view"));
+    }
 }