This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new c5f7ad92aa2 refactor YamlAppenderSwapper (#33011)
c5f7ad92aa2 is described below

commit c5f7ad92aa29bb73d47bafda19d174193dd0cd36
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Sep 26 16:36:11 2024 +0800

    refactor YamlAppenderSwapper (#33011)
    
    * Refactor YamlLoggerSwapper
    
    * Refactor YamlAppenderSwapper
    
    * Refactor YamlAppenderSwapper
---
 .../shardingsphere/logging/yaml/swapper/YamlAppenderSwapper.java    | 6 ------
 .../shardingsphere/logging/yaml/swapper/YamlLoggerSwapper.java      | 6 ------
 2 files changed, 12 deletions(-)

diff --git 
a/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlAppenderSwapper.java
 
b/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlAppenderSwapper.java
index 48b18dd9d5f..8a588e1322c 100644
--- 
a/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlAppenderSwapper.java
+++ 
b/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlAppenderSwapper.java
@@ -28,9 +28,6 @@ public final class YamlAppenderSwapper implements 
YamlConfigurationSwapper<YamlA
     
     @Override
     public YamlAppenderConfiguration swapToYamlConfiguration(final 
ShardingSphereAppender data) {
-        if (null == data) {
-            return null;
-        }
         YamlAppenderConfiguration result = new YamlAppenderConfiguration();
         result.setAppenderName(data.getAppenderName());
         result.setAppenderClass(data.getAppenderClass());
@@ -41,9 +38,6 @@ public final class YamlAppenderSwapper implements 
YamlConfigurationSwapper<YamlA
     
     @Override
     public ShardingSphereAppender swapToObject(final YamlAppenderConfiguration 
yamlConfig) {
-        if (null == yamlConfig) {
-            return null;
-        }
         ShardingSphereAppender result = new 
ShardingSphereAppender(yamlConfig.getAppenderName(), 
yamlConfig.getAppenderClass(), yamlConfig.getPattern());
         result.setFile(yamlConfig.getFile());
         return result;
diff --git 
a/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggerSwapper.java
 
b/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggerSwapper.java
index 3f566720a8b..8546a623017 100644
--- 
a/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggerSwapper.java
+++ 
b/kernel/logging/core/src/main/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggerSwapper.java
@@ -28,9 +28,6 @@ public final class YamlLoggerSwapper implements 
YamlConfigurationSwapper<YamlLog
     
     @Override
     public YamlLoggerConfiguration swapToYamlConfiguration(final 
ShardingSphereLogger data) {
-        if (null == data) {
-            return null;
-        }
         YamlLoggerConfiguration result = new YamlLoggerConfiguration();
         result.setLoggerName(data.getLoggerName());
         result.setLevel(data.getLevel());
@@ -42,9 +39,6 @@ public final class YamlLoggerSwapper implements 
YamlConfigurationSwapper<YamlLog
     
     @Override
     public ShardingSphereLogger swapToObject(final YamlLoggerConfiguration 
yamlConfig) {
-        if (null == yamlConfig) {
-            return null;
-        }
         ShardingSphereLogger result = new 
ShardingSphereLogger(yamlConfig.getLoggerName(), yamlConfig.getLevel(), 
yamlConfig.getAdditivity(), yamlConfig.getAppenderName());
         result.setProps(yamlConfig.getProps());
         return result;

Reply via email to