This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 7f7d0c518eb Remove useless YamlLoggingRuleConfigurationSwapperTest 
(#33015)
7f7d0c518eb is described below

commit 7f7d0c518eb06fd73a420057a30b05ae0af2533c
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Sep 26 23:21:33 2024 +0800

    Remove useless YamlLoggingRuleConfigurationSwapperTest (#33015)
---
 .../logging/rule/LoggingRuleTest.java              |  2 +-
 .../YamlLoggingRuleConfigurationSwapperTest.java   | 65 ----------------------
 2 files changed, 1 insertion(+), 66 deletions(-)

diff --git 
a/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/rule/LoggingRuleTest.java
 
b/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/rule/LoggingRuleTest.java
index 17ff3eb3a79..a44fec3235e 100644
--- 
a/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/rule/LoggingRuleTest.java
+++ 
b/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/rule/LoggingRuleTest.java
@@ -39,7 +39,7 @@ class LoggingRuleTest {
     }
     
     @Test
-    void assertFields() {
+    void assertGetConfiguration() {
         assertThat(loggingRule.getConfiguration().getLoggers().size(), is(1));
         assertThat(loggingRule.getConfiguration().getAppenders().size(), 
is(1));
     }
diff --git 
a/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggingRuleConfigurationSwapperTest.java
 
b/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggingRuleConfigurationSwapperTest.java
deleted file mode 100644
index a15e73b75e8..00000000000
--- 
a/kernel/logging/core/src/test/java/org/apache/shardingsphere/logging/yaml/swapper/YamlLoggingRuleConfigurationSwapperTest.java
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.logging.yaml.swapper;
-
-import org.apache.shardingsphere.logging.config.LoggingRuleConfiguration;
-import org.apache.shardingsphere.logging.logger.ShardingSphereAppender;
-import org.apache.shardingsphere.logging.logger.ShardingSphereLogger;
-import 
org.apache.shardingsphere.logging.yaml.config.YamlLoggingRuleConfiguration;
-import org.junit.jupiter.api.Test;
-
-import java.util.Collections;
-
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.MatcherAssert.assertThat;
-
-class YamlLoggingRuleConfigurationSwapperTest {
-    
-    private final YamlLoggingRuleConfigurationSwapper swapper = new 
YamlLoggingRuleConfigurationSwapper();
-    
-    private final YamlLoggerSwapper loggerSwapper = new YamlLoggerSwapper();
-    
-    private final YamlAppenderSwapper appenderSwapper = new 
YamlAppenderSwapper();
-    
-    @Test
-    void assertSwapToYamlConfiguration() {
-        YamlLoggingRuleConfiguration yamlLoggingRuleConfig = 
swapper.swapToYamlConfiguration(createLoggingRuleConfiguration());
-        assertThat(yamlLoggingRuleConfig.getLoggers().size(), is(1));
-        assertThat(yamlLoggingRuleConfig.getAppenders().size(), is(1));
-    }
-    
-    private LoggingRuleConfiguration createLoggingRuleConfiguration() {
-        return new LoggingRuleConfiguration(Collections.singleton(new 
ShardingSphereLogger("ROOT", "INFO", true, "console")),
-                Collections.singleton(new ShardingSphereAppender("console", 
"ch.qos.logback.core.ConsoleAppender", "[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} 
[%thread] %logger{36} - %msg%n")));
-    }
-    
-    @Test
-    void assertSwapToObject() {
-        LoggingRuleConfiguration loggingRuleConfig = 
swapper.swapToObject(createYamlLoggingRuleConfiguration());
-        assertThat(loggingRuleConfig.getLoggers().size(), is(1));
-        assertThat(loggingRuleConfig.getAppenders().size(), is(1));
-    }
-    
-    private YamlLoggingRuleConfiguration createYamlLoggingRuleConfiguration() {
-        YamlLoggingRuleConfiguration result = new 
YamlLoggingRuleConfiguration();
-        
result.setLoggers(Collections.singleton(loggerSwapper.swapToYamlConfiguration(new
 ShardingSphereLogger("ROOT", "INFO", true, "console"))));
-        
result.setAppenders(Collections.singleton(appenderSwapper.swapToYamlConfiguration(
-                new ShardingSphereAppender("console", 
"ch.qos.logback.core.ConsoleAppender", "[%-5level] %d{yyyy-MM-dd HH:mm:ss.SSS} 
[%thread] %logger{36} - %msg%n"))));
-        return result;
-    }
-}

Reply via email to