linghengqian commented on code in PR #33030:
URL: https://github.com/apache/shardingsphere/pull/33030#discussion_r1779366772
##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/com.github.ben-manes.caffeine/caffeine/2.9.3/reflect-config.json:
##########
@@ -99,19 +99,16 @@
"name":"com.github.benmanes.caffeine.cache.StripedBuffer",
"fields":[{"name":"tableBusy"}]
},
+{
+
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.NodeFactory"},
+ "name":"com.github.benmanes.caffeine.cache.PDWMS",
+ "methods":[{"name":"<init>","parameterTypes":[] }]
+},
{
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.StripedBuffer"},
"name":"java.lang.Thread",
"fields":[{"name":"threadLocalRandomProbe"}]
},
-{
-
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
- "name":"org.apache.shardingsphere.infra.parser.cache.SQLStatementCacheLoader"
-},
-{
-
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-
"name":"org.apache.shardingsphere.sql.parser.core.database.cache.ParseTreeCacheLoader"
-},
Review Comment:
- I noticed that this was introduced via #32633. But the question is, these
two JSONs are actually already located in
`infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json`,
does this affect any unit tests?
##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/com.github.ben-manes.caffeine/caffeine/2.9.3/reflect-config.json:
##########
@@ -99,19 +99,16 @@
"name":"com.github.benmanes.caffeine.cache.StripedBuffer",
"fields":[{"name":"tableBusy"}]
},
+{
+
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.NodeFactory"},
+ "name":"com.github.benmanes.caffeine.cache.PDWMS",
+ "methods":[{"name":"<init>","parameterTypes":[] }]
+},
{
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.StripedBuffer"},
"name":"java.lang.Thread",
"fields":[{"name":"threadLocalRandomProbe"}]
},
-{
-
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
- "name":"org.apache.shardingsphere.infra.parser.cache.SQLStatementCacheLoader"
-},
-{
-
"condition":{"typeReachable":"com.github.benmanes.caffeine.cache.LocalLoadingCache"},
-
"name":"org.apache.shardingsphere.sql.parser.core.database.cache.ParseTreeCacheLoader"
-},
Review Comment:
- I noticed that this was introduced via #32633. But the question is, these
two JSONs are actually already located in
`infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json`,
does this affect any unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
