(shardingsphere) branch master updated: Remove useless @RequiredArgsConstructor of CaseInsensitiveQualifiedTable (#33244)

[jianglongtao]

This is an automated email from the ASF dual-hosted git repository.

jianglongtao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new fd599fb221a Remove useless @RequiredArgsConstructor of 
CaseInsensitiveQualifiedTable (#33244)
fd599fb221a is described below

commit fd599fb221ab25ab9ef969f208c80f4d873f94d4
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Oct 14 18:53:08 2024 +0800

    Remove useless @RequiredArgsConstructor of CaseInsensitiveQualifiedTable 
(#33244)
    
    * Remove useless @RequiredArgsConstructor of CaseInsensitiveQualifiedTable
    
    * Remove useless @RequiredArgsConstructor of CaseInsensitiveQualifiedTable
---
 .../caseinsensitive/CaseInsensitiveQualifiedTable.java        |  2 --
 .../caseinsensitive/CaseInsensitiveQualifiedTableTest.java    | 11 ++++-------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTable.java
 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTable.java
index 4d4be107867..96e4c27bf2c 100644
--- 
a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTable.java
+++ 
b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTable.java
@@ -19,12 +19,10 @@ package 
org.apache.shardingsphere.infra.metadata.caseinsensitive;
 
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 
 /**
  * Case insensitive qualified table.
  */
-@RequiredArgsConstructor
 @Getter
 @EqualsAndHashCode
 // TODO should merge with QualifiedTable
diff --git 
a/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTableTest.java
 
b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTableTest.java
index 27b30b2f6dd..c432694878b 100644
--- 
a/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTableTest.java
+++ 
b/infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/caseinsensitive/CaseInsensitiveQualifiedTableTest.java
@@ -21,19 +21,16 @@ import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class CaseInsensitiveQualifiedTableTest {
     
     @Test
-    void assertToString() {
-        CaseInsensitiveQualifiedTable actual = new 
CaseInsensitiveQualifiedTable(new CaseInsensitiveIdentifier(null), new 
CaseInsensitiveIdentifier("t_order"));
-        assertThat(actual.toString(), is("t_order"));
+    void assertToStringWithNullSchema() {
+        assertThat(new CaseInsensitiveQualifiedTable(null, 
"foo_tbl").toString(), is("foo_tbl"));
     }
     
     @Test
-    void assertToStringThrowsNPE() {
-        CaseInsensitiveQualifiedTable actual = new 
CaseInsensitiveQualifiedTable(null, new CaseInsensitiveIdentifier("t_order"));
-        assertThrows(NullPointerException.class, actual::toString);
+    void assertToStringWithNotNullSchema() {
+        assertThat(new CaseInsensitiveQualifiedTable("foo_schema", 
"foo_tbl").toString(), is("foo_schema.foo_tbl"));
     }
 }