danigiri opened a new pull request, #33393:
URL: https://github.com/apache/shardingsphere/pull/33393
Continuing with Doris parsing support.
In this case `RIGHT` is already implemented and supported by both MySQL and
Doris so ammended the tests and added `STRRIGHT` support which is an alias in
Doris.
Continues to address #31508.
Changes proposed in this pull request:
- Added parsing support for the `STRRIGHT` alias in Doris
- Updated existing MySQL test to reflect that `RIGHT` is also supported by
Doris
- Added `STRRIGHT`-specific test
- Marked `// DORIS ADDED BEGIN|END` Doris-specific changes, and fixed a typo
in existing one
- Added as a `regularFunctionName` which is where `RIGHT` is so no java
changes should be needed
- Executed `SELECT STRRIGHT('foobarbar',4)` in Doris 3.0.2 correctly
#### Next
- get PR id to update release notes
- ~~finish compiling Doris v3 to test the query code~~ my local machine is
not powerful enough
---
Before committing this PR, I'm sure that I have checked the following
options:
- [✅] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [✅] I have self-reviewed the commit code.
- [✅] I have (or in comment I request) added corresponding labels for the
pull request.
- [✅] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [✅] I have made corresponding changes to the documentation.
- [✅] I have added corresponding unit tests for my changes.
- [✅] mvn spotless:apply -Pcheck
- [✅] mvn test -Dtest=InternalDorisParserIT in
shardingsphere/parser/sql/dialect/doris
- [✅] Executed test case in Doris v2.0.3 – SELECT STRRIGHT('foobarbar',4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
