This is an automated email from the ASF dual-hosted git repository.
yx9o pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 86af715e459 Add test cases on DialectIncrementalDumperCreator (#33415)
86af715e459 is described below
commit 86af715e4597c58e2c35f527b8bc4582e5a8ce5a
Author: Liang Zhang <[email protected]>
AuthorDate: Sat Oct 26 20:14:55 2024 +0800
Add test cases on DialectIncrementalDumperCreator (#33415)
---
.../DialectIncrementalDumperCreator.java | 2 +-
.../incremental/IncrementalDumperCreator.java | 2 +-
.../DialectIncrementalDumperCreatorFixture.java | 2 +-
.../dumper/MySQLIncrementalDumperCreator.java | 2 +-
.../dumper/MySQLIncrementalDumperCreatorTest.java | 52 ++++++++++++++++++++++
.../dumper/OpenGaussIncrementalDumperCreator.java | 2 +-
.../OpenGaussIncrementalDumperCreatorTest.java | 52 ++++++++++++++++++++++
.../dumper/PostgreSQLIncrementalDumperCreator.java | 2 +-
.../PostgreSQLIncrementalDumperCreatorTest.java | 52 ++++++++++++++++++++++
.../h2/dumper/H2IncrementalDumperCreator.java | 2 +-
10 files changed, 163 insertions(+), 7 deletions(-)
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreator.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreator.java
index 7a98bed7d7f..eef4aac2e50 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreator.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreator.java
@@ -32,5 +32,5 @@ public interface DialectIncrementalDumperCreator extends
DatabaseTypedSPI {
* @param param create incremental dumper parameter
* @return incremental dumper
*/
- IncrementalDumper createIncrementalDumper(CreateIncrementalDumperParameter
param);
+ IncrementalDumper create(CreateIncrementalDumperParameter param);
}
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/IncrementalDumperCreator.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/IncrementalDumperCreator.java
index b573c4c1039..1705727fdd4 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/IncrementalDumperCreator.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/IncrementalDumperCreator.java
@@ -39,6 +39,6 @@ public final class IncrementalDumperCreator {
public static IncrementalDumper create(final
CreateIncrementalDumperParameter param) {
ShardingSpherePreconditions.checkState(param.getContext().getCommonContext().getDataSourceConfig()
instanceof StandardPipelineDataSourceConfiguration,
() -> new UnsupportedSQLOperationException("Incremental dumper
only support StandardPipelineDataSourceConfiguration"));
- return
DatabaseTypedSPILoader.getService(DialectIncrementalDumperCreator.class,
param.getContext().getCommonContext().getDataSourceConfig().getDatabaseType()).createIncrementalDumper(param);
+ return
DatabaseTypedSPILoader.getService(DialectIncrementalDumperCreator.class,
param.getContext().getCommonContext().getDataSourceConfig().getDatabaseType()).create(param);
}
}
diff --git
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreatorFixture.java
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreatorFixture.java
index 54d19997cc8..15a47a6d723 100644
---
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreatorFixture.java
+++
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/incremental/DialectIncrementalDumperCreatorFixture.java
@@ -22,7 +22,7 @@ import static org.mockito.Mockito.mock;
public final class DialectIncrementalDumperCreatorFixture implements
DialectIncrementalDumperCreator {
@Override
- public IncrementalDumper createIncrementalDumper(final
CreateIncrementalDumperParameter param) {
+ public IncrementalDumper create(final CreateIncrementalDumperParameter
param) {
return mock(IncrementalDumper.class);
}
diff --git
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreator.java
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreator.java
index 3edc2db31d5..497474ceeb4 100644
---
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreator.java
+++
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreator.java
@@ -27,7 +27,7 @@ import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.In
public final class MySQLIncrementalDumperCreator implements
DialectIncrementalDumperCreator {
@Override
- public IncrementalDumper createIncrementalDumper(final
CreateIncrementalDumperParameter param) {
+ public IncrementalDumper create(final CreateIncrementalDumperParameter
param) {
return new MySQLIncrementalDumper(param.getContext(),
param.getPosition(), param.getChannel(), param.getMetaDataLoader());
}
diff --git
a/kernel/data-pipeline/dialect/mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreatorTest.java
b/kernel/data-pipeline/dialect/mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreatorTest.java
new file mode 100644
index 00000000000..941d4051e13
--- /dev/null
+++
b/kernel/data-pipeline/dialect/mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/dumper/MySQLIncrementalDumperCreatorTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.data.pipeline.mysql.ingest.incremental.dumper;
+
+import
org.apache.shardingsphere.data.pipeline.api.type.StandardPipelineDataSourceConfiguration;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.CreateIncrementalDumperParameter;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.DialectIncrementalDumperCreator;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.IncrementalDumperContext;
+import
org.apache.shardingsphere.data.pipeline.mysql.ingest.incremental.binlog.position.MySQLBinlogPosition;
+import
org.apache.shardingsphere.infra.database.core.spi.DatabaseTypedSPILoader;
+import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
+import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.hamcrest.CoreMatchers.instanceOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class MySQLIncrementalDumperCreatorTest {
+
+ private final DatabaseType databaseType =
TypedSPILoader.getService(DatabaseType.class, "MySQL");
+
+ private final DialectIncrementalDumperCreator creator =
DatabaseTypedSPILoader.getService(DialectIncrementalDumperCreator.class,
databaseType);
+
+ @Test
+ void assertCreate() {
+ IncrementalDumperContext dumperContext =
mock(IncrementalDumperContext.class, RETURNS_DEEP_STUBS);
+
when(dumperContext.getCommonContext().getDataSourceConfig()).thenReturn(new
StandardPipelineDataSourceConfiguration(Collections.singletonMap("url",
"jdbc:mock://127.0.0.1/foo_ds")));
+ MySQLBinlogPosition position = mock(MySQLBinlogPosition.class,
RETURNS_DEEP_STUBS);
+ CreateIncrementalDumperParameter param = new
CreateIncrementalDumperParameter(dumperContext, position, null, null, null);
+ assertThat(creator.create(param),
instanceOf(MySQLIncrementalDumper.class));
+ }
+}
diff --git
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreator.java
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreator.java
index 8f2576bead5..29770bb99c2 100644
---
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreator.java
+++
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreator.java
@@ -27,7 +27,7 @@ import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.In
public final class OpenGaussIncrementalDumperCreator implements
DialectIncrementalDumperCreator {
@Override
- public IncrementalDumper createIncrementalDumper(final
CreateIncrementalDumperParameter param) {
+ public IncrementalDumper create(final CreateIncrementalDumperParameter
param) {
return new OpenGaussIncrementalDumper(param.getContext(),
param.getPosition(), param.getChannel(), param.getMetaDataLoader());
}
diff --git
a/kernel/data-pipeline/dialect/opengauss/src/test/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreatorTest.java
b/kernel/data-pipeline/dialect/opengauss/src/test/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreatorTest.java
new file mode 100644
index 00000000000..fbf866aaca0
--- /dev/null
+++
b/kernel/data-pipeline/dialect/opengauss/src/test/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/dumper/OpenGaussIncrementalDumperCreatorTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.data.pipeline.opengauss.ingest.incremental.dumper;
+
+import
org.apache.shardingsphere.data.pipeline.api.type.StandardPipelineDataSourceConfiguration;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.CreateIncrementalDumperParameter;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.DialectIncrementalDumperCreator;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.IncrementalDumperContext;
+import
org.apache.shardingsphere.data.pipeline.postgresql.ingest.incremental.wal.WALPosition;
+import
org.apache.shardingsphere.infra.database.core.spi.DatabaseTypedSPILoader;
+import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
+import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.hamcrest.CoreMatchers.instanceOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class OpenGaussIncrementalDumperCreatorTest {
+
+ private final DatabaseType databaseType =
TypedSPILoader.getService(DatabaseType.class, "openGauss");
+
+ private final DialectIncrementalDumperCreator creator =
DatabaseTypedSPILoader.getService(DialectIncrementalDumperCreator.class,
databaseType);
+
+ @Test
+ void assertCreate() {
+ IncrementalDumperContext dumperContext =
mock(IncrementalDumperContext.class, RETURNS_DEEP_STUBS);
+
when(dumperContext.getCommonContext().getDataSourceConfig()).thenReturn(new
StandardPipelineDataSourceConfiguration(Collections.singletonMap("url",
"jdbc:mock://127.0.0.1/foo_ds")));
+ WALPosition position = mock(WALPosition.class, RETURNS_DEEP_STUBS);
+ CreateIncrementalDumperParameter param = new
CreateIncrementalDumperParameter(dumperContext, position, null, null, null);
+ assertThat(creator.create(param),
instanceOf(OpenGaussIncrementalDumper.class));
+ }
+}
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreator.java
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreator.java
index 6a1254c876d..b8e4af1d629 100644
---
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreator.java
+++
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreator.java
@@ -27,7 +27,7 @@ import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.In
public final class PostgreSQLIncrementalDumperCreator implements
DialectIncrementalDumperCreator {
@Override
- public IncrementalDumper createIncrementalDumper(final
CreateIncrementalDumperParameter param) {
+ public IncrementalDumper create(final CreateIncrementalDumperParameter
param) {
return new PostgreSQLIncrementalDumper(param.getContext(),
param.getPosition(), param.getChannel(), param.getMetaDataLoader());
}
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/test/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreatorTest.java
b/kernel/data-pipeline/dialect/postgresql/src/test/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreatorTest.java
new file mode 100644
index 00000000000..3e40c08dad8
--- /dev/null
+++
b/kernel/data-pipeline/dialect/postgresql/src/test/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/incremental/dumper/PostgreSQLIncrementalDumperCreatorTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.data.pipeline.postgresql.ingest.incremental.dumper;
+
+import
org.apache.shardingsphere.data.pipeline.api.type.StandardPipelineDataSourceConfiguration;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.CreateIncrementalDumperParameter;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.DialectIncrementalDumperCreator;
+import
org.apache.shardingsphere.data.pipeline.core.ingest.dumper.incremental.IncrementalDumperContext;
+import
org.apache.shardingsphere.data.pipeline.postgresql.ingest.incremental.wal.WALPosition;
+import
org.apache.shardingsphere.infra.database.core.spi.DatabaseTypedSPILoader;
+import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
+import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.hamcrest.CoreMatchers.instanceOf;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class PostgreSQLIncrementalDumperCreatorTest {
+
+ private final DatabaseType databaseType =
TypedSPILoader.getService(DatabaseType.class, "PostgreSQL");
+
+ private final DialectIncrementalDumperCreator creator =
DatabaseTypedSPILoader.getService(DialectIncrementalDumperCreator.class,
databaseType);
+
+ @Test
+ void assertCreate() {
+ IncrementalDumperContext dumperContext =
mock(IncrementalDumperContext.class, RETURNS_DEEP_STUBS);
+
when(dumperContext.getCommonContext().getDataSourceConfig()).thenReturn(new
StandardPipelineDataSourceConfiguration(Collections.singletonMap("url",
"jdbc:mock://127.0.0.1/foo_ds")));
+ WALPosition position = mock(WALPosition.class, RETURNS_DEEP_STUBS);
+ CreateIncrementalDumperParameter param = new
CreateIncrementalDumperParameter(dumperContext, position, null, null, null);
+ assertThat(creator.create(param),
instanceOf(PostgreSQLIncrementalDumper.class));
+ }
+}
diff --git
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2IncrementalDumperCreator.java
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2IncrementalDumperCreator.java
index bd7fdab3922..871eb955f6d 100644
---
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2IncrementalDumperCreator.java
+++
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/h2/dumper/H2IncrementalDumperCreator.java
@@ -29,7 +29,7 @@ import static org.mockito.Mockito.mock;
public final class H2IncrementalDumperCreator implements
DialectIncrementalDumperCreator {
@Override
- public IncrementalDumper createIncrementalDumper(final
CreateIncrementalDumperParameter param) {
+ public IncrementalDumper create(final CreateIncrementalDumperParameter
param) {
return mock(IncrementalDumper.class);
}
