gxgmy521 commented on issue #33831: URL: https://github.com/apache/shardingsphere/issues/33831#issuecomment-2510378222
> But then again, the unit tests I wrote didn't have connection leaks, there was always extra logic to close all connections. You need to provide independent unit tests. Sorry I do not know how to mock the connection leaks in the unit tests 。 You mention that "there was always extra logic to close all connections." I guess you are talking about the capabilities of the connection pool (ie, the “removeAbandoned” parameter in Tomcat JDBC pool )?In my opinion ,we should close the connection immediately instead of handing it over to the connection pool。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
