This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new b799a530d72 Refactor ShardingSphereStatisticsRefreshEngine (#33883)
b799a530d72 is described below

commit b799a530d72a9f80625e28c4b13bd008270b3a5d
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Dec 2 16:30:59 2024 +0800

    Refactor ShardingSphereStatisticsRefreshEngine (#33883)
---
 .../refresher/ShardingSphereStatisticsRefreshEngine.java         | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/ShardingSphereStatisticsRefreshEngine.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/ShardingSphereStatisticsRefreshEngine.java
index 58058101150..7482b8b90d1 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/ShardingSphereStatisticsRefreshEngine.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/ShardingSphereStatisticsRefreshEngine.java
@@ -102,8 +102,7 @@ public final class ShardingSphereStatisticsRefreshEngine {
         }
     }
     
-    private void collectForDatabase(final String databaseName, final 
ShardingSphereDatabaseData databaseData,
-                                    final ShardingSphereMetaData metaData, 
final ShardingSphereStatistics statistics) {
+    private void collectForDatabase(final String databaseName, final 
ShardingSphereDatabaseData databaseData, final ShardingSphereMetaData metaData, 
final ShardingSphereStatistics statistics) {
         for (Entry<String, ShardingSphereSchemaData> entry : 
databaseData.getSchemaData().entrySet()) {
             if 
(metaData.getDatabase(databaseName).containsSchema(entry.getKey())) {
                 collectForSchema(databaseName, entry.getKey(), 
entry.getValue(), metaData, statistics);
@@ -122,11 +121,11 @@ public final class ShardingSphereStatisticsRefreshEngine {
     
     private void collectForTable(final String databaseName, final String 
schemaName, final ShardingSphereTable table,
                                  final ShardingSphereMetaData metaData, final 
ShardingSphereStatistics statistics) {
-        Optional<ShardingSphereStatisticsCollector> dataCollector = 
TypedSPILoader.findService(ShardingSphereStatisticsCollector.class, 
table.getName());
+        Optional<ShardingSphereStatisticsCollector> statisticsCollector = 
TypedSPILoader.findService(ShardingSphereStatisticsCollector.class, 
table.getName());
         Optional<ShardingSphereTableData> tableData = Optional.empty();
-        if (dataCollector.isPresent()) {
+        if (statisticsCollector.isPresent()) {
             try {
-                tableData = dataCollector.get().collect(databaseName, table, 
metaData.getDatabases(), 
contextManager.getMetaDataContexts().getMetaData().getGlobalRuleMetaData());
+                tableData = statisticsCollector.get().collect(databaseName, 
table, metaData.getDatabases(), metaData.getGlobalRuleMetaData());
                 // CHECKSTYLE:OFF
             } catch (final Exception ex) {
                 // CHECKSTYLE:ON

Reply via email to