This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 95bb5aa631e Remove useless GlobalLockContext (#34116)
95bb5aa631e is described below
commit 95bb5aa631e30895f7a70b8606c7d376267e62a6
Author: Liang Zhang <[email protected]>
AuthorDate: Sat Dec 21 22:31:54 2024 +0800
Remove useless GlobalLockContext (#34116)
---
.../mode/lock/global/GlobalLockContext.java | 41 ----------------
.../mode/lock/global/GlobalLockContextTest.java | 57 ----------------------
2 files changed, 98 deletions(-)
diff --git
a/mode/core/src/main/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContext.java
b/mode/core/src/main/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContext.java
deleted file mode 100644
index 266a1a70404..00000000000
---
a/mode/core/src/main/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContext.java
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.mode.lock.global;
-
-import lombok.RequiredArgsConstructor;
-import org.apache.shardingsphere.infra.lock.LockContext;
-import org.apache.shardingsphere.mode.lock.LockPersistService;
-
-/**
- * Global lock context.
- */
-@RequiredArgsConstructor
-public final class GlobalLockContext implements
LockContext<GlobalLockDefinition> {
-
- private final LockPersistService<GlobalLockDefinition>
globalLockPersistService;
-
- @Override
- public boolean tryLock(final GlobalLockDefinition lockDefinition, final
long timeoutMillis) {
- return globalLockPersistService.tryLock(lockDefinition, timeoutMillis);
- }
-
- @Override
- public void unlock(final GlobalLockDefinition lockDefinition) {
- globalLockPersistService.unlock(lockDefinition);
- }
-}
diff --git
a/mode/core/src/test/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContextTest.java
b/mode/core/src/test/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContextTest.java
deleted file mode 100644
index b281c8e4e0d..00000000000
---
a/mode/core/src/test/java/org/apache/shardingsphere/mode/lock/global/GlobalLockContextTest.java
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.shardingsphere.mode.lock.global;
-
-import org.apache.shardingsphere.mode.lock.LockPersistService;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.ExtendWith;
-import org.mockito.Mock;
-import org.mockito.junit.jupiter.MockitoExtension;
-
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-@ExtendWith(MockitoExtension.class)
-class GlobalLockContextTest {
-
- private final GlobalLockDefinition lockDefinition = new
GlobalLockDefinition("foo_lock");
-
- @Mock
- private LockPersistService<GlobalLockDefinition> lockPersistService;
-
- private GlobalLockContext lockContext;
-
- @BeforeEach
- void init() {
- lockContext = new GlobalLockContext(lockPersistService);
- }
-
- @Test
- void assertTryLock() {
- when(lockPersistService.tryLock(lockDefinition,
3000L)).thenReturn(true);
- assertTrue(lockContext.tryLock(lockDefinition, 3000L));
- }
-
- @Test
- void assertUnlock() {
- lockContext.unlock(lockDefinition);
- verify(lockPersistService).unlock(lockDefinition);
- }
-}
