omkar-shitole commented on issue #32280: URL: https://github.com/apache/shardingsphere/issues/32280#issuecomment-2574689348
In this [PR](https://github.com/apache/shardingsphere/pull/34227) , I have added e2e test cases to cover similar and related queries for the `ON CONFLICT` clause, as highlighted in the referenced [issue](https://github.com/apache/shardingsphere/pull/34227). Additionally, I noticed that the current implementation fails to execute `ON CONFLICT ... DO NOTHING`, resulting in the following error: <details> <summary>Click to expand error stack trace</summary> '''Exception in thread "main" java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.tree.ParseTree.accept(org.antlr.v4.runtime.tree.ParseTreeVisitor)" because "tree" is null at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18) at org.apache.shardingsphere.sql.parser.postgresql.visitor.statement.PostgreSQLStatementVisitor.visitOptOnConflict(PostgreSQLStatementVisitor.java:712)Exception in thread "main" java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.tree.ParseTree.accept(org.antlr.v4.runtime.tree.ParseTreeVisitor)" because "tree" is null at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18) at org.apache.shardingsphere.sql.parser.postgresql.visitor.statement.PostgreSQLStatementVisitor.visitOptOnConflict(PostgreSQLStatementVisitor.java:712)''' </details> This PR addresses both issues by fixing the error and ensures that queries with DO NOTHING are successfully executed. I kindly request you to proceed with the review and merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
