tristaZero commented on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-612835490 @TaoZhiMLND Hi Very appreciated your contribution to this community. I think you took a lot of time on this PR. Good job! :-) Recently, I am working on a similar issue with you, so could I get some advice from you? The question is whether it is possible to hide the `KeyGenerateAlgorithmFactoryBean` in xml from users? Like this one below, ``` From <bean id="incrementAlgorithm" class="org.apache.shardingsphere.shardingjdbc.spring.namespace.factorybean.KeyGenerateAlgorithmFactoryBean"> <property name="type" value="INCREMENT" /> </bean> To <bean id="incrementAlgorithm" name="type" value="INCREMENT" /> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
